Repository navigation
Adds column families property get - #40
Merged
Merged
Conversation
kasperisager
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
rocksdb_property_getonly wraps theDB::GetProperty(name, value)overload, which targets the default column family. Anything storing its data in a named family reads0from every property, and nearly all the useful ones are per-family:total-sst-files-size,estimate-live-data-size,total-blob-file-size,estimate-pending-compaction-bytes.Proposal
rocksdb_column_family_property_get(db, column_family, name, value), wrapping the CF overloadrocksdb_property_getis untouched and nothing downstream breaksTests
Write to a named family, flush it, then read
rocksdb.total-sst-files-sizeboth ways against the same data: the column family call reports non-zero,rocksdb_property_getreports zero. Also covers the default family reading zero through the new call, andUV_ENOENTfor an unknown property name.Swapping the implementation back to the default overload fails that first assertion, so the test discriminates between the two overloads rather than passing by construction.