Skip to content

add rocksdb_property_get() - #37

Merged
kasperisager merged 2 commits into
holepunchto:mainfrom
telamon:feature/property-value
Jul 2, 2026
Merged

kasperisager merged 2 commits into
holepunchto:mainfrom
telamon:feature/property-value

Conversation

@telamon

@telamon telamon commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Wish to expose statistics in rocksdb-native but I forgot to export the actual call in the previous pr #29

handle->GetProperty("rocksdb.options-statistics")

With this pr, statistics can be enabled and read.

@telamon
telamon requested a review from a team July 2, 2026 02:31
@tony-go

tony-go commented Jul 2, 2026

Copy link
Copy Markdown

No tests added ?

Comment thread src/rocksdb.cc Resolved
Comment thread src/rocksdb.cc Resolved
@telamon

telamon commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

oops yes that was an quite an unfocused patch, apologies.
please re-view again, thanks!

@telamon telamon changed the title expose getter for rocksdb properties add rocksdb_property_get() Jul 2, 2026
@telamon
telamon requested a review from kasperisager July 2, 2026 18:27

@kasperisager kasperisager left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid! 👌

@kasperisager
kasperisager merged commit 79007c3 into holepunchto:main Jul 2, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants