Avoid reusing closing socket pool routes - #257
Open
marcus-pousette-hp wants to merge 5 commits into
Open
Conversation
marcus-pousette-hp
force-pushed
the
fix/avoid-closing-socket-pool-routes
branch
from
July 16, 2026 10:48
b872b5c to
55711e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusable socket routes were previously removed only after the underlying socket emitted close. During the interval between calling socket.close() and receiving that event, route lookup could return a socket with socket.closing === true.
Attempting to reuse that route causes an unnecessary failed connection attempt before falling back to the normal connection path, potentially increasing reconnect latency and flakiness during connection churn.
This change:
Co-authored with AI