Skip to content

Fully remote proof encode decode - #950

Merged
lejeunerenard merged 1 commit into
mainfrom
fully-remote-proof-encode-decode
Nov 12, 2026
Merged

lejeunerenard merged 1 commit into
mainfrom
fully-remote-proof-encode-decode

Conversation

@mafintosh

Copy link
Copy Markdown
Contributor

No description provided.

@mafintosh
mafintosh requested a review from a team November 12, 2026 14:24
@greptile-apps

greptile-apps Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5 Tier: apex

[Low impact] The PR appears safe to merge; the earlier request for direct helper tests remains non-blocking.

Fix All in Claude CodeFindings

  1. P2 New proof helpers lack tests ▶
Fix with agent prompt
### Issue 1
lib/fully-remote-proof.js:undefined-146
The new `encode: false` branch and exported `encode`/`decode` helpers have no direct tests. Existing tests only use the default buffer return, so a broken object return or export could go unnoticed. Add coverage that encodes an unencoded proof, verifies it, and checks that `encode(decode(buffer))` preserves the bytes.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Summary

Adds reusable helpers for fully remote proofs.

  • Fully remote proofs can now be shared as objects or bytes.

Reviews (2) · Last reviewed commit: "Expose encode/decode for fully remote pr..." · Reviewed by Greptile

Comment thread lib/fully-remote-proof.js
proof: { request: 0, ...proof }
}

return encode ? encodeProof(result) : result

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 New proof helpers lack tests

The new encode: false branch and exported encode/decode helpers have no direct tests. Existing tests only use the default buffer return, so a broken object return or export could go unnoticed. Add coverage that encodes an unencoded proof, verifies it, and checks that encode(decode(buffer)) preserves the bytes.

Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/fully-remote-proof.js
Line: 146

Comment:
**New proof helpers lack tests**

The new `encode: false` branch and exported `encode`/`decode` helpers have no direct tests. Existing tests only use the default buffer return, so a broken object return or export could go unnoticed. Add coverage that encodes an unencoded proof, verifies it, and checks that `encode(decode(buffer))` preserves the bytes.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code

@lejeunerenard
lejeunerenard merged commit e08d1f2 into main Nov 12, 2026
6 checks passed
@lejeunerenard
lejeunerenard deleted the fully-remote-proof-encode-decode branch November 12, 2026 17:42
@greptile-apps greptile-apps Bot mentioned this pull request Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants