Repository navigation
Fully remote proof encode decode - #950
Merged
Merged
Conversation
[Low impact] The PR appears safe to merge; the earlier request for direct helper tests remains non-blocking.
|
| proof: { request: 0, ...proof } | ||
| } | ||
|
|
||
| return encode ? encodeProof(result) : result |
There was a problem hiding this comment.
The new encode: false branch and exported encode/decode helpers have no direct tests. Existing tests only use the default buffer return, so a broken object return or export could go unnoticed. Add coverage that encodes an unencoded proof, verifies it, and checks that encode(decode(buffer)) preserves the bytes.
Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/fully-remote-proof.js
Line: 146
Comment:
**New proof helpers lack tests**
The new `encode: false` branch and exported `encode`/`decode` helpers have no direct tests. Existing tests only use the default buffer return, so a broken object return or export could go unnoticed. Add coverage that encodes an unencoded proof, verifies it, and checks that `encode(decode(buffer))` preserves the bytes.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
lejeunerenard
approved these changes
Nov 12, 2026
Merged
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.