Repository navigation
Delete the default session's data in deleteCore - #133
Merged
Merged
Conversation
deleteCore cleared the core's own rows and the data of its named sessions, but not the data of the default session, so blocks, tree nodes, bitfield pages and user data of a deleted core stayed in the store forever. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chm-diederichs
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deleteCoreclears the core's rows and its named sessions' data, but not the default session's data (blocks, tree, bitfield, user data). With the core rows gone that data is unreachable, so it leaks: a purged hypercore left 151 of its 157 keys behind.core.data(ptr.dataPointer).Needed for hypercore's
purge(): holepunchto/hypercore#881.Open question: corestore's
staticify()creates a second core sharing the samecorePointer/dataPointer.deleteCoreon either already removes the shared core rows, so this doesn't make that case worse, but it may want explicit handling.🤖