Fix stale cache after move operation - #58
Merged
Merged
Conversation
mafintosh
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WriteBatch serialization renumbers pointer objects in place (k.seq/k.offset = ), and those objects are shared into older nodes' delta lists through CompressedArray.commit(). The decoder rebuilds nodes purely from their own block's delta list, so the in-memory delta is what gets serialized. The design assumption is that an old node object is never re-serialized after a newer flush and autobee's undo (move() to an older length) violates exactly that: the node cache hands back the old root object whose delta pointers now reference the newer, just-abandoned block, and the post-undo re-apply flushes garbage references to disk.
commit()'s slice(0, -this.updates) with updates === 0 (slice(0, -0) = slice(0, 0)) wipes the live node's delta
claude opus 4.8