Skip to content

Refactor of Hyperbee._rollback() #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caolan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor of Hyperbee._rollback() #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c4da0a
Refactor of Hyperbee._rollback()
caolan Feb 9, 2026
b014129
Comment: remove TODOs for rollback error case
caolan Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 14 additions & 19 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,32 +272,27 @@ class Hyperbee extends EventEmitter {
}

async _rollback(config) {
const expected = this.unbatch

let n = expected
let length = this.root === EMPTY ? 0 : this.root.seq + 1
let seq = this.root.seq
let context = this.context
let count = this.unbatch

while (n > 0 && length > 0 && expected === this.unbatch) {
const seq = length - 1
while (count) {
const blk = await context.getBlock(seq, 0, config)

if (!blk.previous) {
length = 0
break
}

if (!blk.previous) break
seq = blk.previous.seq
context = await context.getContext(blk.previous.core, config)
length = blk.previous.seq + 1
n--
count--
}

if (expected === this.unbatch) {
this.context = context
this.root = length === 0 ? EMPTY : context.createTreeNode(0, length - 1, 0, false, null)
this.unbatch = 0
this.emit('update')
if (count) {
// There was an attempt to rollback more batches than exist.
this.root = EMPTY
} else {
this.root = context.createTreeNode(0, seq, 0, false, null)
}
this.context = context
this.unbatch = 0
this.emit('update')
}

update(root = null) {
Expand Down