Skip to content

Fix allow latest test - #191

Merged
lejeunerenard merged 3 commits into
holepunchto:mainfrom
HDegroote:fix-allow-latest-test
Nov 9, 2026
Merged

lejeunerenard merged 3 commits into
holepunchto:mainfrom
HDegroote:fix-allow-latest-test

Conversation

@HDegroote

Copy link
Copy Markdown
Contributor

Made 2 mistakes in the initial test, and they hid each other:

  • Wrong assert
  • Wrong way to pass the opt

@HDegroote
HDegroote requested a review from a team November 9, 2026 16:32
@greptile-apps

greptile-apps Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge.

Summary

Fixes the test for overriding alwaysLatestBlock.

  • The latest-block test checks that one core can opt out.

Reviews (3) · Last reviewed commit: "Use absent" · Reviewed by Greptile

Comment thread test/basic.js Resolved
lejeunerenard
lejeunerenard previously approved these changes Nov 9, 2026
@lejeunerenard
lejeunerenard merged commit 0939467 into holepunchto:main Nov 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants