Repository navigation
fix: drop a core a peer opens mid-purge instead of failing the store's close - #185
Open
shavtvalishvili wants to merge 1 commit into
Open
shavtvalishvili wants to merge 1 commit into
shavtvalishvili wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_attachMaybechecksstorage.hasCoreand then opens the core. If apurge()deletes the core between those two steps,core.ready()throwsSTORAGE_EMPTY, and the failed core stays inthis.cores, so the nextstore.close()rejects with the same error.Now a core that fails to open there is dropped from
this.coresand the peer's open is ignored, as if the check had said the core was missing.validation
The new test in
test/purge.jsstubshasCoreto report the purged core once, which simulates the race, and it fails without the fix (close()rejects withSTORAGE_EMPTY).npm test(node and bare) passes 55/55, andnpm run lintis clean.We hit this on a peer that purges cores while other peers still replicate them, and we currently carry it as a patch on 7.12.6.