fix: trim whitespace in unescaped (triple mustache) tags#61
Open
Yanhu007 wants to merge 1 commit into
Open
Conversation
{{{ String }}} with spaces around the tag name did not match data
keys because the extracted tag name retained leading/trailing
whitespace. Only {{{String}}} without spaces worked.
Apply strings.TrimSpace to the extracted tag name in both
top-level and section-level unescaped tag parsing.
Fixes hoisie#51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51
Problem
Unescaped tags with spaces around the variable name fail to resolve:
The tag extraction for
{{{...}}}strips the outer braces viatag[1:len(tag)-1]but doesn't trim the resulting whitespace, leaving the tag name asStringinstead ofString.Fix
Apply
strings.TrimSpaceafter extracting the inner tag name, matching the behavior of other tag types (which already use TrimSpace during initial tag extraction).All existing tests pass.