Allowed for template-lookup callbacks; fixed indentation#35
Open
yourheropaul wants to merge 1 commit into
Open
Allowed for template-lookup callbacks; fixed indentation#35yourheropaul wants to merge 1 commit into
yourheropaul wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I added a mechanism to provide a callback function which can load partials by name from some external cache. This requirement came about while I was working on a project which stores its templates in the database (and cached in memory) rather than on the disk, but also needs to load templates dynamically.
The additions are on lines 46-63, and 147-150 – it should be pretty intuitive. There is also test coverage, which hooks into the existing test fixtures.
And yes, I passive-agressively reformatted the code to be inline with idiomatic go standards. I make no apology for this. Sorry, but that's the way it is.
Thanks for this package, it's pretty boss!
PMF