Native Alpaca for SWS - #38
Open
MichelMoriniaux wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Howard, do not merge this PR (at least not yet, I want your opinion and I need to finish testing if this goes in main)
This is an implementation of the Alpaca spec on top of the SWS, it implements Telescope, Focuser, Rotator and Observing conditions.
I have done conformance tests only for Observing conditions and Telescope and all basic tests pass.
I have not tested Focuser and rotator as I do not have a controller equipped for those.
I have not been able to run full conformance tests as I have not been able to get a 10.28u to run properly on my mount (I get weird runaways I did not have in 10.25p)
the only issue I have experienced using this code is that it is best to close all browsers using SWS when using Alpaca as some collisions may occur (timeouts in Alpaca). This issue may be the showstopper that makes this whole effort moot, I seem to recall a conversation in the mailing list about how this may just not be possible
In any case whether this is valuable or not there are a few HTTP1.1 compliance bugs that are corrected in this code that may be valuable for the project (see the diffs in
src/lib/ethernet/webServer/WebServer.cpp) as well as an oversight in commands ( see src/libApp/cmd/Cmd.cpp )Anyway let me know if this is of value to the project.
Maybe the right way to do this is as an alternative to SWS? For the plugin website version I was thinking of making a separate plugin in addition to the adds to Website