Repository navigation
✨ say.tone: play the listening chime on Discord - #51
Merged
Merged
Conversation
The Discord adapter renders the same two-note chime as the Vexa bot (src/tone.ts) and plays it into the voice channel at once, without waiting. It is dropped when a line is queued or playing, when one is already playing or when the bot has no voice, a say cuts it, and it never throws. Fixes #50 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #50
Discord had no listening tone, so
say.tonealways answeredplayed:falsethere. Now:src/tone.tsrenders the chime in code, the same design as the Vexa bot's (G5 then C6, 100 ms each, 8 ms attack, 25 ms release, decay, peak 18% of full scale, 24 kHz mono). No assets. It is about 200 ms long, matching the bot so Betty chimes alike everywhere.DiscordAdapter.tone()upsamples it to 48 kHz stereo and plays it through the same player and Opus path as speech. It returns at once and plays asynchronously, so hive's 2 second timeout is never an issue.played:false) when asayis queued or playing, when a tone is already playing, when there is no TTS (no player, the bot has no voice) or when the bot is not in the channel. Asaythat starts during the chime stops it first, so speech is never delayed. Never throws.Only the companion still has no tone (hivecommons/quorum-companion#12).
🤖 Generated with Claude Code