Repository navigation
🔒 Hosted Zoom links require an allowlisted hostname - #48
Merged
Merged
Conversation
…TED_DOMAINS) Any host with a Zoom-shaped path and a passcode was accepted and its URL sent to Vexa as meeting_url. The hosted branch now needs an explicit allowlist (default zoom-lfx.platform.linuxfoundation.org; empty turns it off) and always refuses IP literals, localhost, dotless hosts, URL credentials, http and non-443 ports unless the entry names them. Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Contributor
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the owner's decision A on #46.
parseMeetingUrlnow needs a hostname inQUORUM_ZOOM_HOSTED_DOMAINS(comma-separated exact hostnames;*.x/.xmatch subdomains on the dot boundary, not the apex). Default:zoom-lfx.platform.linuxfoundation.orgonly. Set but empty turns the branch off.parseMeetingUrl; read from env inloadConfigand passed by the service.Fixes #46
🤖 Generated with Claude Code