Skip to content

🔒 Hosted Zoom links require an allowlisted hostname - #48

Merged
kubestellar-prow[bot] merged 2 commits into
mainfrom
fix/zoom-hosted-allowlist
Nov 18, 2026
Merged

kubestellar-prow[bot] merged 2 commits into
mainfrom
fix/zoom-hosted-allowlist

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Implements the owner's decision A on #46.

  • Hosted-Zoom branch of parseMeetingUrl now needs a hostname in QUORUM_ZOOM_HOSTED_DOMAINS (comma-separated exact hostnames; *.x/.x match subdomains on the dot boundary, not the apex). Default: zoom-lfx.platform.linuxfoundation.org only. Set but empty turns the branch off.
  • Always refused regardless of the list: IP literals (v4/v6), localhost, dotless hosts, characters outside [a-z0-9.-] after URL normalisation, URL credentials, http, ports other than 443 (unless the entry says host:port).
  • Allowlist is a parameter of parseMeetingUrl; read from env in loadConfig and passed by the service.
  • zoom.us, zoomgov.com, Teams, Meet and Discord branches untouched.
  • Tests: events.example.org is now negative; positive LFX case kept; suffix spoofs, userinfo trick, IP literals, localhost, port, http, empty env, second domain, wildcard.
  • Behavior change: hosted links on any host other than the allowlist are now rejected. Documented in README and docs/contract.md (the repo has no CHANGELOG).

Fixes #46

🤖 Generated with Claude Code

…TED_DOMAINS)

Any host with a Zoom-shaped path and a passcode was accepted and its URL sent
to Vexa as meeting_url. The hosted branch now needs an explicit allowlist
(default zoom-lfx.platform.linuxfoundation.org; empty turns it off) and always
refuses IP literals, localhost, dotless hosts, URL credentials, http and
non-443 ports unless the entry names them.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • check-failure

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@clubanderson clubanderson added lgtm Approved by a Hive merger/owner for auto-merge on green CI approved labels Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow
kubestellar-prow Bot merged commit 87eede4 into main Nov 18, 2026
8 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the fix/zoom-hosted-allowlist branch November 18, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes lgtm Approved by a Hive merger/owner for auto-merge on green CI size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sec-check] parseMeetingUrl accepts any hostname for "hosted Zoom" links — SSRF-shaped: an agent-supplied URL can direct Vexa's bot anywhere

1 participant