Skip to content

🐛 fix: scan the vexa fork in quorum CI - #47

Merged
hivecommons-hive[bot] merged 2 commits into
mainfrom
scanner/fix-45
Nov 18, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
mainfrom
scanner/fix-45

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closes #45

hivecommons/vexa cannot hold its own scanning workflows: GITHUB_TOKEN cannot push under .github/workflows/ there. This adds a quorum-owned scheduled workflow (quorum-scan-vexa, daily + manual) that checks out vexa main and runs OSV-Scanner (SHA-pinned, v2.7.1) with the fork's osv-scanner.toml. No secrets or PATs, nothing changed in vexa.

Limits: OSV-Scanner has no severity threshold, so any unignored vulnerability fails the run (broader than HIGH/CRITICAL; reviewed ignores go in vexa's osv-scanner.toml). Code scanning and Trivy image scanning are not covered; the vexa docs correction (security/known-advisories.md, trivy-ignore header) remains a separate small vexa PR.

🤖 Generated with Claude Code

— hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.327

Closes #45

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

ℹ️ Sentinel: informational, author is trusted (hive agent), merge is not blocked. Head 81c11163f0da matched:

  • sensitive_path: changes 1 sensitive path(s) (.github/workflows/quorum-scan-vexa.yml)

No sentinel-alert label was added. The finding is recorded in the dashboard Security tab and /api/sentinel; set sentinel.trusted_authors_block: true to block trusted authors too.

Review findings from reviewer-2 (folded here because this head already carries its hive review):

The workflow is sound and least-privilege: contents: read, persist-credentials: false, no secrets, and both action SHAs match upstream tags (checkout v7.0.1, osv-scanner-action v2.7.1, via git ls-remote). It matches #45 and the limits the body states.

One thing for a person: the PR's own osv-scanner check is FAILURE on this head, because the pull_request trigger (line 18) runs the real scan of vexa main. I did not read the job log, so I can't say whether this is genuine advisories or config. Either vexa's osv-scanner.toml needs reviewed ignores first, or the PR trigger should be dropped or made non-blocking. It also adds a new scheduled workflow that scans another repo, which is a trust-surface change.

Findings not on a changed line

  • .github/workflows/quorum-scan-vexa.yml:18: pull_request here runs the real scan against vexa main, and the osv-scanner check is red on this head. Either land vexa's reviewed ignores first, or drop this trigger so editing the workflow doesn't depend on vexa's advisory state.

hive/awaiting-ci: osv-scanner failed on real vexa vulnerabilities, not on this diff. The scan is now non-blocking on pull_request only; scheduled and manual runs still fail on findings. CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: db3cbeb

— hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.327

Review findings from reviewer (folded here because this head already carries its hive review):

This adds a new file under .github/workflows/, which is a trust surface, so I am routing it rather than approving.

What I checked at db3cbeb:

  • quorum-scan-vexa.yml:17-18 sets permissions: contents: read. There are no secrets, no pull_request_target, and checkout uses persist-credentials: false (:34). Both actions are SHA-pinned.
  • hivecommons/vexa is public and has osv-scanner.toml at its root, so --config=vexa/osv-scanner.toml (:43) resolves.
  • The pull_request trigger is limited to this workflow's own path. continue-on-error (:38) means vexa findings do not block quorum PRs.
  • The PR body matches the diff, including the stated limit that OSV-Scanner has no severity threshold.

Nothing here looks defective. The open question for the owner is policy: quorum workflows will pull and scan vexa@main daily, and any unignored advisory there fails quorum's scheduled run.

Evidence bundle `#47db3cbeb` sha256:5e11c478caa4696cce1a89cfb0c59f65e7276b08369a1ccc6cca03f2f5b2d7b9 — download from the dashboard or `hivectl review evidence #47`.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether quorum should own a daily scheduled scan of the hivecommons/vexa fork (new workflow file), given it adds a CI workflow.

I read the new quorum-scan-vexa.yml. permissions: contents: read, no secrets, persist-credentials: false, and both actions are SHA-pinned (checkout 3d3c42e… = v7.0.1, osv-scanner-action 6bc832e… = v2.7.1, verified against upstream tags). The PR body's limits (no severity threshold; any unignored vuln fails the run) match the workflow. Looks correct to me.

Routing to a person because it adds a new workflow file, and the policy/ownership choice of scanning the fork from quorum is theirs.

— hive: agent=reviewer backend=claude model=claude-sonnet-5-5 claude=2.1.327

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Scanner triage: osv-scanner is red because the newly added vexa scan is working. It reports 14 known vulnerabilities in the vexa tree's lockfiles (next 16.4.1, picomatch, opentelemetry-api, dnspython, and others). The cause is not this diff. Fixes belong in hivecommons/vexa. Options: bump the lockfiles there, or add a reviewed osv-scanner.toml ignore list for the unfixable picomatch advisories. I'm deferring rather than weakening the scan.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.327

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/scanner: osv-scanner fails on this PR's own diff (baseline triage: isolated, FIX_DIFF). Scanning the vexa fork now surfaces 14 real findings (8 High): picomatch GHSA-fc5q-39xc-vjpf (no fixed version), next 16.4.1 -> 16.4.5, dnspython 2.9.0 -> 2.9.2, opentelemetry-api 1.45.1 -> 1.45.2, fast-xml-parser, minimatch. vexa/osv-scanner.toml also has unused ignores (GHSA-hp3w-g68c-fv3c, GHSA-gcqx-w48m-w2h4). Fixing means bumping lockfiles in the vexa repo or adding reasoned ignores, which is a security-posture call, so I am not adding ignores unilaterally. Deferring to a maintainer. Job log: https://github.com/hivecommons/quorum/actions/runs/44265209914/job/134667921185


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.327

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 18, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Decision needed: @clubanderson should decide whether quorum CI may schedule a daily scan that checks out and scans another repo (hivecommons/vexa) from a new workflow file.

Routing, not a defect: this PR adds .github/workflows/quorum-scan-vexa.yml, a CI workflow (trust surface), so a person should sign off.

What I verified at db3cbeb:

  • Permissions are contents: read, no secrets, checkout uses persist-credentials: false, both actions are SHA-pinned (checkout SHA matches ci.yml). No pull_request_target.
  • hivecommons/vexa has osv-scanner.toml at the root, so --config=vexa/osv-scanner.toml resolves.
  • continue-on-error is true only on pull_request, so scheduled/manual runs fail on any unignored vuln as the PR body states. Matches the body's stated limits.
  • It runs scheduled code against vexa main, so a vexa change can turn quorum's scheduled run red; that is the intended alert, but it is the maintainer's call that quorum owns it.

Open question (unverified): whether google/osv-scanner-action/osv-scanner-action@6bc832e… is the commit tagged v2.7.1; I could not check the tag here.

Code reads correct to me; I have not approved anything.

— hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.327

@hivecommons-hive hivecommons-hive Bot added stage/085-needs-decision PR parked on a human decision: sentinel alert, hold/needs-decision label or human-only rule and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Needs a decision, not a merge:

  • the reviewer swarm returned requires_human @db3cbeb
  • the review found: the reviewer marked this change high-risk
  • reviewer question: @clubanderson should decide whether quorum CI may run a scheduled workflow that checks out and scans the separate hivecommons/vexa repo.
  • the automerge lane will not merge this unattended

Head: verdict requires_human @db3cbeb, 5/5 checks green, DCO yes, soak 0s of 10m0s.

What to do: approve this head (db3cbeb) to merge as-is, or leave a changes requested review (or reply /hive decision <what to change>) and the hive will push the fix.

How to release it:

  • After reading the verdict, a trusted merger can submit a GitHub Approve review for the current head and the lane clears the hold on its next pass; /hive approve replies on a PR are acknowledged but not consumed.

Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.

@hivecommons-hive hivecommons-hive Bot removed the stage/085-needs-decision PR parked on a human decision: sentinel alert, hold/needs-decision label or human-only rule label Nov 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

/approve

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hivecommons-hive[bot]

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

/hive decision approve #47: small, necessary, low-risk change on a green head

Rationale: small low-risk changes (CI pins, read-only RBAC, warning text, workflow hygiene) are approved once checked.

Hive decided: Approved for merge.
Why: A small, low-risk change on a green branch.
What happens next: The merge queue merges this PR once its checks are green — expected within 30 min.
If it doesn't happen: A maintainer can merge it by hand or send it back for a new commit; approving again does not help.

Decided by the hive at @clubanderson's request as the owner's delegate under the owner-delegate policy (rule small-low-risk).

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Approved by @clubanderson for Hive auto-merge on green CI.

@hivecommons-hive hivecommons-hive Bot added the lgtm Approved by a Hive merger/owner for auto-merge on green CI label Nov 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Hive queued this PR but could not set the prow/lgtm commit status, so Prow may strip the lgtm label and the auto-merge queue may not hold.

@hivecommons-hive
hivecommons-hive Bot merged commit cfaf31b into main Nov 18, 2026
8 of 9 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-45 branch November 18, 2026 11:49
@hivecommons-hive hivecommons-hive Bot removed the role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) label Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off dco-signoff: yes lgtm Approved by a Hive merger/owner for auto-merge on green CI size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sec-check] hivecommons/vexa fork has no CVE/code/dependency scanning — upstream scanners removed in 9d6209e, allow-lists now stale

0 participants