Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions dist/cli.test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/cli.test.js.map

Large diffs are not rendered by default.

43 changes: 43 additions & 0 deletions dist/resolver.test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/resolver.test.js.map

Large diffs are not rendered by default.

51 changes: 51 additions & 0 deletions dist/ui.test.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/ui.test.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

19 changes: 19 additions & 0 deletions src/cli.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -265,3 +265,22 @@ test('@file array syntax reads one value per line', () => {
assert.match(runs[1], /Hi Bob/);
rmSync(dirname(cwd), { recursive: true, force: true });
});

test('ui subcommand parses --port and surfaces server errors', async () => {
// Occupy a port so `promptargs ui` fails fast and deterministically —
// this exercises the ui dispatch path without leaving a server running.
const { createServer } = await import('node:net');
const blocker = createServer();
await new Promise<void>(resolve => blocker.listen(0, '127.0.0.1', resolve));
const { port } = blocker.address() as { port: number };

try {
const { cwd, home } = makeDirs();
const res = runCli(['ui', `--port=${port}`], cwd, home);
assert.strictEqual(res.status, 1);
assert.match(res.stderr, new RegExp(`Port ${port} is in use`));
rmSync(dirname(cwd), { recursive: true, force: true });
} finally {
await new Promise(resolve => blocker.close(resolve));
}
});
56 changes: 56 additions & 0 deletions src/resolver.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { describe, it, before, after } from 'node:test';
import assert from 'node:assert';
import { mkdtempSync, writeFileSync, rmSync, mkdirSync } from 'node:fs';
import { join } from 'node:path';
import { PassThrough } from 'node:stream';
import { resolve } from './resolver.js';
import type { TemplateVar } from './parser.js';

Expand Down Expand Up @@ -164,4 +165,59 @@ describe('resolve glob expansion', () => {
const r = await resolve([v('pa_f')], { pa_f: pattern }, false);
assert.strictEqual(r.values.pa_f, pattern);
});

it('survives an unreadable glob base (file used as directory)', async () => {
// "plain-file/*.md": the base exists but readdirSync throws ENOTDIR;
// the expander must skip it instead of crashing, leaving a literal.
const file = join(tmp, 'plain-file');
writeFileSync(file, 'not a dir');
const pattern = join(file, '*.md');
const r = await resolve([v('pa_f')], { pa_f: pattern }, false);
assert.strictEqual(r.values.pa_f, pattern);
assert.strictEqual(r.iterations.length, 1);
});
});

describe('resolve interactive prompting', () => {
// resolve()'s ask() reads from process.stdin via readline; swap in a
// PassThrough so answers can be scripted without a child process.
async function withStdin<T>(input: string, fn: () => Promise<T>): Promise<T> {
const fake = new PassThrough();
const desc = Object.getOwnPropertyDescriptor(process, 'stdin')!;
Object.defineProperty(process, 'stdin', { value: fake, configurable: true });
try {
fake.write(input);
return await fn();
} finally {
Object.defineProperty(process, 'stdin', desc);
}
}

it('asks for missing values and trims the answer', async () => {
const r = await withStdin(' spaced answer \n', () =>
resolve([v('pa_ask')], {}, true),
);
assert.strictEqual(r.values.pa_ask, 'spaced answer');
assert.deepStrictEqual(r.iterations, [{ pa_ask: 'spaced answer' }]);
});

it('expands a comma-separated interactive answer into iterations', async () => {
const r = await withStdin('one,two,three\n', () =>
resolve([v('pa_ask')], {}, true),
);
assert.deepStrictEqual(
r.iterations.map(i => i.pa_ask),
['one', 'two', 'three'],
);
});

it('prefers flags and defaults over prompting', async () => {
// A sentinel answer is queued: if resolve prompted for either var it
// would consume it and the assertions below would fail.
const r = await withStdin('SENTINEL_NOT_CONSUMED\n', () =>
resolve([v('pa_flag'), v('pa_dflt', 'd')], { pa_flag: 'f' }, true),
);
assert.strictEqual(r.values.pa_flag, 'f');
assert.strictEqual(r.values.pa_dflt, 'd');
});
});
Loading
Loading