-
Notifications
You must be signed in to change notification settings - Fork 0
[quality] resolver interactive ask path, glob failure branch, and ui fatal exits are untested #44
Copy link
Copy link
Closed
Labels
agent/qualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancehelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmationHive verified that a merged PR references or claims this issue; pending confirmationqualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancetestingCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenance
Description
Activity
Metadata
Metadata
Assignees
Labels
agent/qualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancehelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmationHive verified that a merged PR references or claims this issue; pending confirmationqualityCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenancetestingCreated by Hive for agent-filed issue provenanceCreated by Hive for agent-filed issue provenance
Finding
Coverage run (
node --test --experimental-test-coverageon dist) shows the remaining untested paths after PR #36 are concentrated insrc/resolver.tsandsrc/ui.tserror/interactive branches:resolver.tsinteractiveask()path (lines ~122–131, 163–171) — 0% covered. This is the default UX (promptargs "<template>"with missing vars): answer trimming, comma-array expansion of interactive answers, and flag/default precedence over prompting were all unverified.resolver.tsglobreaddirSyncfailure branch (lines ~63–64) — a glob segment whose base exists but is not readable/not a directory (e.g.file.txt/*.md) must be skipped, not crash resolution.ui.tsfatal exits —EADDRINUSEhandler (port-in-use hint + exit 1) and missingui.html(reinstall hint + exit 1) untested.cli.tsuisubcommand dispatch (lines ~76–80) —--portflag parsing never exercised.Overall line coverage before: 93.27%; resolver.ts 87.8%, ui.ts 84.8%.
Recommendation
Add tests for each path:
resolver.test.ts.startUIfatal exits (they callprocess.exit) inui.test.ts.cli.test.tse2e forui --port=<occupied>(deterministic, no lingering server).Priority
Filed by quality agent (hold-gated mode)
🐝 Hive Agent:
quality| Instance:hosted-available-oke-11-placeholder-r05x| SHA:b922f25— hive: agent=quality backend=copilot model=claude-fable-5 copilot=1.0.88