Repository navigation
test: pin README --dangerous row to attach.ts DANGEROUS_FLAGS - #230
Merged
hivecommons-hive[bot] merged 2 commits intoOct 12, 2026
Merged
Conversation
The README --dangerous row names the flag each CLI gets, but #225 added omp: '--approval-mode yolo' to DANGEROUS_FLAGS without updating it, so the docs advertised three CLIs while attach knew four. Add a support-matrix guard that parses both and requires them to agree on CLI set and exact flag text, and add the missing omp entry to the row. Refs #229 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <quality@hive.kubestellar.io>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/M
kubestellar-prow
Bot
deleted the
quality/test-dangerous-flag-readme-parity
branch
October 12, 2026 03:02
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
test/cli-support-matrix.test.jsalready pins the README--clirow toCLI_COMMANDS, but nothing pinned the--dangerousrow toDANGEROUS_FLAGS. #225 addedomp: '--approval-mode yolo'toDANGEROUS_FLAGSand the README row kept listing only claude/codex/goose.This PR:
DANGEROUS_FLAGSentries fromsrc/attach.tsand the`flag` for clipairs from the README--dangerousrow, and requires the two to agree on both the CLI set and the exact flag text (verified by mutation: dropping goose from the row and changing codex's flag text both fail with a pointed message);`--approval-mode yolo` for ompentry to that row so the guard passes onmain.Refs #229 — that issue is the production-side defect:
attach()single-quotes the whole--approval-mode yolostring so omp receives one argv token. The fix lives insrc/attach.ts, outside the quality lane, so this PR only pins the documentation; when the flag text changes as part of the fix, this guard will require the README row to follow.No changelog fragment: test + doc-table correction, not a user-visible behaviour change.
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88