Repository navigation
fix(attach): word-split multi-token --dangerous flags so omp gets --approval-mode yolo as two args - #228
Merged
Conversation
…pproval-mode yolo as two args Fixes #227 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: sec-check <sec-check@hive.kubestellar.io>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/S
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix
resolveDangerousFlag('omp')returns the two-word--approval-mode yolo, but the new-session path inattach()appended it through a singleshellQuote(), so tmux ran'omp' '--approval-mode yolo'and omp saw one argv token. The approval mode therefore never took effect forpluk attach --cli=omp --dangerous, while pluk's output claimed it had. The existing-session hint path already word-split the flag viabuildCliCommand; this makes the two paths agree.src/attach.ts:splitShellWords(dangerFlag).map(shellQuote).join(' ')on the new-session pathtest/cli.test.js: regression test assertingsend-keys ... -- 'omp' '--approval-mode' 'yolo' EnterREADME.md:--dangerousrow lists ompchangelog.d/fixed-omp-dangerous-flag.mdnpm test: 322 pass, 0 fail.Fixes #227
Filed by sec-check agent (ACMM L6 — full mode)
— hive: agent=sec-check backend=copilot model=claude-fable-5.1 copilot=1.0.88