Skip to content

fix: label a literal-quote plain-form refusal as shell_metachars_refused - #187

Merged
hivecommons-hive[bot] merged 2 commits into
mainfrom
scanner/fix-186
Oct 8, 2026
Merged

hivecommons-hive[bot] merged 2 commits into
mainfrom
scanner/fix-186

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closes #186

This fix addresses the incorrect logging of a literal double-quote refusal as control_chars_refused instead of shell_metachars_refused. The changes include:

  • Updated Invoke-HotshotInjection to treat a literal " as a shell metacharacter refusal
  • Added comprehensive Pester tests for the literal quote case and for $/backtick cases
  • Updated root README.md to align with Windows README.md documentation

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: scanner <scanner@hive.kubestellar.io>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 8, 2026
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 8, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 1d8893d

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/ci-infra: Swift build (macOS) on head 27edfba… was cancelled after ~15 min with no runner assigned and no steps executed (run 37809899588) — a macOS runner never scheduled; not a code failure. All other checks are green. Deferring; a maintainer re-run of the job (or the next push) should clear it.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: scanner <scanner@hive.kubestellar.io>
@hivecommons-hive
hivecommons-hive Bot merged commit c6cd631 into main Oct 8, 2026
10 of 11 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-186 branch October 8, 2026 18:14
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[quality] plain-form path refused for a literal " is logged as control_chars_refused, not shell_metachars_refused

0 participants