[quality] main.swift injection pipeline (783 lines) has zero coverage — extract pure logic into HotshotCore #58

Finding

Sources/hotshot/main.swift is 783 lines with zero test coverage — it is an executable target, so swift test never touches it. It contains the entire live injection pipeline:

• detectTargetCLI — tty resolution + fallback-to-.claude policy
• enrichClipboardWithSavedImage — clipboard trust/rewrite decisions and hotshot-<timestamp>.png naming (the watcher's self-reinjection guard depends on this prefix)
• injectViaITerm2 / injectViaGenericAppleScript / sendCtrlV / showNotification — AppleScript source construction interpolating escaped user-controlled paths into quoted literals (security-relevant: appleScriptEscaped is tested, but the scripts it is embedded into are not)
• checkClipboard — the refuse-to-paste-untrusted-clipboard decision path

By contrast, HotshotCore and the Linux/Windows scripts are well tested (22 XCTest cases, 640-line bash harness, Pester suite). The repo's testability convention is already established: pure logic lives in HotshotCore, glue in main.swift.

Recommendation

Extract the pure parts of the above into HotshotCore and test them there, mirroring the existing ttyScript/typedScreenshotText pattern:

1. iterm2InjectionScript(text:autoReturn:autoFocus:) -> String and genericInjectionScript(text:bundleID:autoReturn:) -> String — pure AppleScript builders; test that escaped input cannot break out of the quoted literal and that autoReturn/autoFocus toggles produce the expected script shape.
2. screenshotSavePath(dir:date:) -> String — the hotshot-yyyyMMdd-HHmmss.png naming, so the hotshot- prefix contract shared with newestInjectableScreenshot is pinned by a test.
3. A commands(onTTY:) output parser (parsePSOutput(_: String) -> [String]) separated from the Process spawn.

This is a production refactor, so the quality agent is not PRing it (quality PRs are test-only). Behavior must be preserved exactly; main.swift keeps thin wrappers.

Priority

• Impact: high (injection + escaping paths are the app's security surface)
• Effort: medium

Filed by quality agent (ACMM L4/L6 — full mode)

🐝 Hive Agent: quality | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=quality backend=copilot model=claude-fable-5 copilot=1.0.88