[quality] scripts/bundle.sh untested — plist generation and --install kill/relaunch have no tests; CI wiring needs human (workflows perm)

[hivecommons-hive]

Finding

scripts/bundle.sh (81 lines) has zero test coverage. CI shellchecks it but never executes it. It generates the app's Info.plist (bundle id, LSUIElement, NSAppleEventsUsageDescription — the permission string injection depends on), lays out the .app bundle, and in --install mode kills a running instance by pid, replaces /Applications/Hotshot.app, and relaunches. A regression here (e.g. a plist typo or the kill/copy order flipping) ships silently.

By contrast, linux/install.sh and linux/hotshot-capture.sh both have hermetic test suites run by the CI shell-tests job.

Recommendation

1. Add a hermetic bash test suite scripts/tests/bundle.test.sh (stub swift/pgrep/kill/open; divert /Applications writes into a call log) covering: bundle layout, Info.plist keys, stale-bundle replacement, failed-build abort, and both --install branches. Done in the companion PR.
2. Wire it into CI. This needs a .github/workflows/ci.yml edit, which this agent's token cannot push (no workflows permission) — a human or an ISSUES_PRS_MERGE agent must land it. Exact change, in the shell-tests job after "Run Linux installer tests":

      - name: Run bundle script tests
        run: bash scripts/tests/bundle.test.sh

Optionally also append scripts/tests/bundle.test.sh to the shellcheck step's file list (it passes shellcheck -S warning today).

Priority

• Impact: medium (release packaging + permission plist correctness)
• Effort: low (test suite already written; CI wiring is two lines)

---

Filed by quality agent (hold-gated mode)

🐝 Hive Agent: quality | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=quality backend=copilot model=claude-fable-5 copilot=1.0.88

[hivecommons-hive]

Verification (quality agent)

Checked against main @ 6f9ed1e:

• ✅ Test suite landed via [quality] cover scripts/bundle.sh: bundle layout, Info.plist keys, --install kill/relaunch (Refs #45) #46: scripts/tests/bundle.test.sh is on main and passes locally (29/29, covering bundle layout, Info.plist keys, failed-build abort, and both --install kill/relaunch branches).
• ❌ CI wiring still missing: .github/workflows/ci.yml shellchecks scripts/bundle.sh (line 30) but never executes the test suite — no bash scripts/tests/bundle.test.sh step exists, so the suite is dead weight until wired.

Still needs a human or ISSUES_PRS_MERGE agent (this agent's token lacks the workflows permission). Exact change, in the shell-tests job after "Run Linux installer tests":

      - name: Run bundle script tests
        run: bash scripts/tests/bundle.test.sh

Optionally also append scripts/tests/bundle.test.sh to the shellcheck file list on line 30.

---

Verified by quality agent (ACMM L4/L6 — full mode)

🐝 Hive Agent: quality | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=quality backend=copilot model=claude-fable-5 copilot=1.0.88

[hivecommons-hive]

A merged PR referenced this issue without closing it. Carrying the remainder back here so the issue timeline shows what is still open.

• [quality] cover scripts/bundle.sh: bundle layout, Info.plist keys, --install kill/relaunch (Refs #45) #46 — [quality] cover scripts/bundle.sh: bundle layout, Info.plist keys, --install kill/relaunch (Refs [quality] scripts/bundle.sh untested — plist generation and --install kill/relaunch have no tests; CI wiring needs human (workflows perm) #45) ([quality] cover scripts/bundle.sh: bundle layout, Info.plist keys, --install kill/relaunch (Refs #45) #46) — needs human

Remainder from the PR body:

wiring this test into the CI shell-tests job requires a .github/workflows/ci.yml edit this agent's token cannot push — exact two-line change is in the issue

This comment is edited in place by the task-list sweep on every cycle; it is not duplicated.