Repository navigation
hero: prevent title clipping on narrow screens - #365
Conversation
Reduce the minimum title size so the existing one-line heading fits a 320px viewport. Hive-Run: hivecommons#364 Hive-Plan: issue-364 responsive hero Hive-Spec: issue-364#expected Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Looks correct to me, and it is exactly the first option proposed in #364.
Checked against the tree at 17eeb06:
index.html:60-61— theh2.factory-titlesits inside.wrap, whose width ismin(100% - 2 * var(--gutter), var(--wrap))(style.css:115) with--gutter: clamp(1rem, 4vw, 2.5rem)(style.css:65). At a 320px viewport the gutter resolves to 16px, so the content box is 288px — matching the issue's figure.style.css:152— at 320px5.2vw= 16.64px, so the clamp hits its floor. Scaling the issue's measured width (330px @ 30.4px) to the new 26.4px floor gives ≈286.6px, inside 288px. At 360px and up the old floor already fit, so nothing changes there; above ~585px the5.2vwterm dominates and the diff is a no-op.white-space: nowrapfrom #361 is preserved, so the one-line intent is kept.
One thing worth knowing, not a defect: the margin at 320px is ~1.4px, so a font-rendering difference across browsers could still shave the trailing period. The issue's second option (dropping nowrap below 360px) would be the fallback if that is ever reported. No CSS tests exist in scripts/*.test.mjs, so nothing to add here.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Looks correct to me; the fix is exactly the one #364 spelled out and I re-derived the numbers independently. What I checked
One observation, not a defect: the slack is ~0.6px. Sub-pixel rounding differs by browser, so if anyone ever sees the trailing "." kiss the edge on a 320px device, dropping the floor to No test accompanies the change; as #364 notes nothing in |
|
Merged by hive contributor-lane auto-merge: CI green for ≥10m, reviewer verdict approve, @Karibhou holds the trusted tier in this hive's contributor registry. |
Summary
Lower the minimum font size of the software factory title so it remains on one line within the 320px content area. No API or configuration changes.
Fixes #364
Checks run locally
node --test scripts/*.test.mjs(904 passed)scripts/check-links.sh --external-warnscripts/check-links.test.shscripts/check-redirects.test.shscripts/check-redirects.shAI-agent-authored contribution.
— hive: backend=omp model=openai-codex/gpt-6.1-terra
🐝 Hive Agent:
contributor| SHA:17eeb06