Repository navigation
test(check-links): pin the site-absolute project-site probe URL - #363
Conversation
The project-site case asserted the probe URL only for the root-relative form; the site-absolute form was checked only for the absence of an internal miss, which the fake curl's default 200 arm satisfies for any URL. Re-rooting origin + original URL instead of origin + normalized path kept the self-test at 132/132; this case fails under that mutant. Fixes #362 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Looks correct to me, and the test does what the body says.
- Applied the PR and ran
bash scripts/check-links.test.sh: 135 passed, 0 failed. - Mutated
scripts/check-links.sh:225fromurl="https://hivecommons.dev${local_path}"tourl="https://hivecommons.dev${url}"(the origin + original-URL regression the body describes): the two pre-existingproject-sitecases still pass — the fakecurl's*broken*arm (check-links.test.sh:35) answers 404 regardless of the host prefix — and only the two new assertions fail (133/2). So the new case is the only thing pinning the probe URL's composition. is_project_site_pathstrips?…before the prefix match (check-links.sh:28) andnormalize_internal_pathstrips thehttps://www.hivecommons.devorigin (:76), so thewww.+ query-string path in the new fixture exercises both as claimed.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Read Reproduced the discrimination claim locally: with line 225 mutated to Test-only change, no edit to the checker. Looks correct to me. Evidence bundle `#36304670e3` sha256:05f43c87bfb17b1bc345d15d7ba61d5f354b327cbea75c9d64e94cd2c3b666a6 — download from the dashboard or `hivectl review evidence #363`. |
Test Improvement
Adds one fixture case to
scripts/check-links.test.shso the project-site arm's site-absolute form is pinned, not just the root-relative one.Why: the existing
project-sitecase only checks thathttps://hivecommons.dev/software-factory/is not reported as an internal miss and that the run ends withExternal failures: 0. The fakecurlanswers200 finefor any URL it does not recognise, so the composition of the probe URL for that form was never asserted — a regression that re-rootsorigin + original URL(yieldinghttps://hivecommons.devhttps://hivecommons.dev/…) kept the self-test at 132/132. The new case linkshttps://www.hivecommons.dev/software-factory/broken/?v=1and requires the error line to namehttps://hivecommons.dev/software-factory/broken/?v=1exactly; under that mutant it fails (134 passed, 1 failed), unmutated it passes (135/0). It also covers thewww.prefix thatnormalize_internal_pathstrips and keeps the query string throughis_project_site_path.No change to
check-links.shitself.Fixes #362
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88