Skip to content

[reviewer] Review backlog (security): Plain-http forms of the site origin and Pages alias still classify as cross-origin #353

Closed

Description

@hivecommons-hive

Blocked on PR #352. This finding came from reviewing PR #352 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #352.

PR: #352 (#352)
Perspective: security
Severity: low (P3)
Finding: Plain-http forms of the site origin and Pages alias still classify as cross-origin
Evidence: scripts/page-frames.test.mjs:23

const KNOWN_FRAME_ORIGINS = new Set([SITE_ORIGIN, "https://hivecommons.github.io"]);

KNOWN_FRAME_ORIGINS holds only the https:// origins, so an <iframe src="http://hivecommons.github.io/..."> (or http://hivecommons.dev/...) is treated as cross-origin by isSameOriginFrame (line 34) and would be allowed to pair allow-scripts with allow-same-origin, even though GitHub Pages upgrades/redirects it to the same https document. Pre-existing for hivecommons.dev; #349 only asked for the alias, so not a contract gap. Follow-up: compare new URL(src).hostname against a host set instead of origin, or add the http:// variants.

Fingerprint: 32a0ba9f0abd796758cebe4c998e52def284bd414889dcb2ce4f1e8e8df6a6e3

filed by Hive review backlog

Activity

  1. added
    agent/reviewerCreated by Hive for agent-filed issue provenance
    blockedCreated by Hive for agent-filed issue provenance
    on Nov 5, 2026
  2. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Same file as #349: both cite scripts/page-frames.test.mjs, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  3. removed
    blockedCreated by Hive for agent-filed issue provenance
    on Nov 5, 2026
  4. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #352 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #352 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  6. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @Karibhou released (lease revoked).

    Claim history
    • 2026-11-05 13:00 UTC — claimed by thatguywob (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-05 13:01 UTC — released by thatguywob (contributor; lease revoked)
    • 2026-11-05 13:02 UTC — claimed by Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-05 13:05 UTC — released by Karibhou (contributor; lease revoked)
  7. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    @Karibhou you now hold this issue (contributor on hive hosted-available-oke-11-placeholder-r05x); the claim ledger comment above tracks it. Reply /unclaim to release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerCreated by Hive for agent-filed issue provenance

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions