You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (security): Plain-http forms of the site origin and Pages alias still classify as cross-origin #353
Blocked on PR #352. This finding came from reviewing PR #352 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #352.
PR: #352 (#352)
Perspective: security
Severity: low (P3)
Finding: Plain-http forms of the site origin and Pages alias still classify as cross-origin
Evidence: scripts/page-frames.test.mjs:23
KNOWN_FRAME_ORIGINS holds only the https:// origins, so an <iframe src="http://hivecommons.github.io/..."> (or http://hivecommons.dev/...) is treated as cross-origin by isSameOriginFrame (line 34) and would be allowed to pair allow-scripts with allow-same-origin, even though GitHub Pages upgrades/redirects it to the same https document. Pre-existing for hivecommons.dev; #349 only asked for the alias, so not a contract gap. Follow-up: compare new URL(src).hostname against a host set instead of origin, or add the http:// variants.
Same file as #349: both cite scripts/page-frames.test.mjs, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.
Unblocked: #352 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
@Karibhou you now hold this issue (contributor on hive hosted-available-oke-11-placeholder-r05x); the claim ledger comment above tracks it. Reply /unclaim to release.
Activity
hivecommons-hive commentedon Nov 5, 2026
Same file as #349: both cite
scripts/page-frames.test.mjs, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.filed by Hive review backlog
hivecommons-hive commentedon Nov 5, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #352 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 5, 2026
Unblocked: #352 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Nov 5, 2026
🔓 Claim by @Karibhou released (lease revoked).
Claim history
thatguywob(contributor on hive hosted-available-oke-11-placeholder-r05x)thatguywob(contributor; lease revoked)Karibhou(contributor on hive hosted-available-oke-11-placeholder-r05x)Karibhou(contributor; lease revoked)hivecommons-hive commentedon Nov 5, 2026
@Karibhou you now hold this issue (contributor on hive hosted-available-oke-11-placeholder-r05x); the claim ledger comment above tracks it. Reply
/unclaimto release.fix(page-frames): classify HTTP site URLs as same-origin (#356)