Repository navigation
π Stage: GitHub's transient mergeable "unknown" keeps the PR's stage - #19381
Merged
hivecommons-hive[bot] merged 2 commits intoNov 20, 2026
Conversation
GitHub reports mergeable_state "unknown" while it recomputes a merge, and the contributor lane then stops before admission, review or CI with reason mergeable-unknown. The stage engine read that as an approved head with nothing left for its author (a weak 080), and another lane's weak opinion could stand in for the silent contributor lane, so an unchanged head dropped for one pass: projectbluefin/utah-packages#1222 went 090 -> 080 -> 090 on a no-linked-issue refusal, and a conflicting PR at 072 could read 090. mergeable-unknown is now "no opinion", like base-refresh:merge-guard (hivecommons#16819): ClassifyStage abstains, ResolveStage drops other lanes' weak opinions on such a pass (an owned opinion still applies), and the merge train keeps the head's human-merge verdict instead of clearing it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1 Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Evidence bundle `#19381a98c0a9` sha256:23e000038c093d4b5ef8051daa12aba707142f462b577d6f05db121c26c61987 β download from the dashboard or `hivectl review evidence #19381`.merged by Hive trusted-author auto-merge: author |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GitHub reports a PR's
mergeable_stateasunknownfor a moment while it recomputes the merge, which it does after the base moves. On those passes an unchanged PR could leave its stage and come back on the next pass:contributor-lane:no-linked-issue), so it waits for a person atstage/090-ready-for-human-merge. It dropped to080-awaiting-merge-admissionwith reasonmergeable-unknownand came back, twice in one evening (9:43 PM and 11:43 PM EST, back about 30 minutes later each time).Cause
unknown, the contributor lane returnsmergeable-unknownbefore admission, review or CI (contributorLaneConflictReason). That part is by design (π Keep conflicting contributor PRs out of human-merge stageΒ #12859: unknown means wait).untrusted-author-rolegives a 090 candidate, so a conflicting PR at 072 could read 090 for a pass.noteMergeTrainOutcometreated the unevaluated pass like a handoff and deleted the human-merge verdict.Fix
mergeable-unknownis now "no opinion", the same waybase-refresh:merge-guardis (#16819):ClassifyStageabstains for it (new constantprstage.StageReasonMergeableUnknown).ResolveStagedrops other lanes' weak opinions on a pass where a lane reported it, and abstains under that reason. An owned opinion from another lane, such as a red required check, still applies. The reconciler (derivePR) goes through the same function, so both agree.noteMergeTrainOutcomeignores it, so the head's human-merge verdict survives.Known limits:
unknown. Normally that is one pass, because the read itself makes GitHub compute the merge. It is the same open-ended shape as the merge guard.Tests
TestClassifyStageMergeableUnknownIsNoOpinioncovers the reason with and without a verdict.TestResolveStageMergeableUnknownKeepsTheStagecovers the contributor lane alone and with a weak trust opinion;derivePRabstains onmergeable-unknown, and an owned opinion still wins.TestMergeableUnknownPassKeepsHumanMerge: a no-linked-issue PR stays at 090.TestMergeableUnknownPassKeepsConflictReturn: a conflicting, refused PR stays at 072.TestMergeableUnknownPassKeepsAdmittedStage: a soaking PR stays at 095.TestMergeTrainUnknownOutcomeKeepsHumanMergeVerdict.Nothing was run locally (AGENTS.md).
gofmt -land the docs citation check are clean, and CI is the first build.π€ Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1