Repository navigation
✨ feature: let spokes sync their own registration repos - #19252
hivecommons-hive[bot] wants to merge 7 commits into
Conversation
Gate sync-repos separately, retain proofs for active repos, and persist new requests separately until the owner proves them. Hive-Run: #19236 Hive-Plan: Hub registration protocol rollout #19056 step 4 Hive-Spec: RFC-18642#3-hive-to-hub-record-sync Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Reject an all-new repo list without changing the registration. Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
The runner can hit a transient Go proxy failure after the main module download succeeds, because the pinned tool resolves its own dependencies. Retry the tool install with bounded backoff and preserve its final error. Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
…ate stays in sync Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Security review at bc209fa: no in-scope blocker. Key auth is checked under the store lock against the addressed record only, foreign and missing IDs both return 404, the body is limited to op and repos, protected fields are restored by update(), and the flag defaults off. One low out-of-scope note is inline.
-- hive: agent=ci-maintainer backend=claude model=claude-sonnet-5-5 claude=2.1.328
| return | ||
| } | ||
| if !hubV1SyncReposEnabled() { | ||
| writeJSONError(w, http.StatusNotFound, "sync-repos is not enabled") |
There was a problem hiding this comment.
Low, out-of-scope: a key-shaped bearer skips requireAuth, so the body is read (up to the limit) and the global store write lock is taken in update() before the key is checked. Wrong keys return 404 without a save, but each request still takes the lock. Consider a read-lock key check before the body read, or confirm that a rate limiter covers this route.
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Review follow-ups: 1 open of 1 (below
|
|
scanner triage @bc209fa: branch is already up to date with v5 (no merge needed). Failing check is native-queue-policy: 'gate: skipped on bc209fa (per-PR provider verdict, not a shared CI incident)'. Sign-off, build, and test checks are green. The failure is not caused by this diff; it needs a gate re-evaluation (next push or maintainer re-run). Merge stays manual per the carried fence. Deferring. 🐝 Hive Agent: |
native-queue-policy resolved the `gate` evidence to the skipped Feedback Wanted `gate` job (a pull_request `closed` run left on this head SHA when #19243 was superseded) instead of docker.yml's successful one. That is a per-head artifact; a new head SHA gets a clean check set. No source change. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Supersedes #19243 (adopted in place, re-homed because a hive commit on the contributor branch cannot carry a squash-safe sign-off; original commits by @Karibhou preserved).
Closes #19236
This branch is #19243's head
bc209fa00990as pushed by @Karibhou (forkKaribhou/hive), unchanged. Last lane reason on the original:check-failing:build-go.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.Merge stays manual (
contributor-lane:workflow-path, carried from #19243): the PR edits CI workflow / action files, which the lane never merges unattended. The hive repairs CI here but will not merge this PR; a maintainer reviews and merges it once green. Do not remove the<!-- hive:carried-fencemarker.Sign-off attribution: the original PR would squash the App's signed fixes as the contributor. This App-authored superseder keeps every original commit and sign-off unchanged and attributes the squash to the App instead. DCO and all merge gates still apply here.