Repository navigation
✨ feature: record per-hive profile sharing consent - #19171
Conversation
Add signed-session profile editing and versioned, opt-in hub consent. No data is delivered to hives in this phase. Hive-Run: hivecommons#19160 Hive-Plan: Customers hub consent phase 1 Hive-Spec: customers-hub-consent#phases Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Karibhou is now trusted for contributor-lane merging in this hive (last 5 merged PRs: no reverts or sentinel alerts). Applies to their open and future PRs here; CI, review verdicts, diff fences, soak and branch protection still apply. |
|
/ok-to-test |
|
@Karibhou this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity. |
|
@hivecommons-hive[bot]: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
UI render evidenceRender evidence captured. Built from
These are fixture renders, not live data: the page was built from the PR head and filled with synthetic data from |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Update source line numbers shifted by the hub profile consent changes. Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
needs-human: Prow has not run this fork PR's presubmits. Its author is not one of Prow's trusted users, so the trigger plugin waits for A maintainer can comment |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether the phase-1 consent store and page may land while its governing design PR #19167 is still open with changes requested?
Read the new consent handlers and store (customer_consent.go, customer_consent_store.go, profile_share.go) against the tree. I found no defect in them, so the open point is sequencing, not code. This is a personal-data consent feature (a risk class), and its disclosure text and retention rules are fixed by a design that has not been accepted.
What I verified:
requireCustomerSharing(customer_consent.go) refuses bearer tokens and impersonation, and wrapsrequireAuth, whoseisCSRFSafecheck (saas_auth.go:24) covers the PUT, POST and DELETE routes. The cookie isSameSite=Lax, which is a second layer.- A grant requires
user.Hives[hiveID] != "". Withdrawal does not, so a person can always withdraw after losing access. - The consent file is written through a 0600 temp file and rename, with
customerConsentMuserialising writes. Withdrawn records are discarded aftercustomerConsentRetentiononce they have a delivery stamp. A record with no delivery stamp is dropped at once on withdrawal. - With
HIVE_HUB_CUSTOMERS_SHARE_ENABLEDoff, the routes return 404 before any auth work.
Why a person should decide:
- Per #19160, the design is in #19167. That PR is still open with changes requested, and it is the source for the retention window (
customerConsentRetention = 90 * 24 * time.Hour) and the disclosurecustomerConsentTextVersion = "1". If #19167 changes either, merging this first locks in text that people have already consented to under version 1. - #19160 is labelled
hive/claimed-by-human, and this PR comes from a fork. Please confirm the contributor is the claimant. - The PR touches
src/docs/api-reference/hub-server.md, which the sibling #19063 also edits (conflicts check reports a conflict there), so expect a rebase whichever lands second.
Suggestion, not a defect: the PR body says the Go suite is left to CI. The new tests in customer_consent_test.go and profile_share_test.go are what CI will run; nothing there needs a local check.
-- hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.327
Replace inline styles on the Scale Controls status card with shared design tokens. Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
|
I left the disclosure, retention, and default-off behavior unchanged. Landing before the governing design is approved, and confirming the issue claim, remain maintainer decisions. The failed test shard traced to the four inline styles in the new Scale Controls card; |
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. stage 095-pre-merge-soak → 060-reviewed: untrusted-author-role Ready for a human merge: verdict approved The hive never approves on your behalf: |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether the per-hive profile-sharing consent model and disclosure text in this PR can land, since it creates a new personal-data consent record the hub will later share with spokes.
This adds a consent store for personal profile data (name, organization) with withdrawal and account-deletion cleanup, behind HIVE_HUB_CUSTOMERS_SHARE_ENABLED (off by default; the body says phase 1 sends nothing to spokes). That is privacy and legal-adjacent policy: what the disclosure says, how long consent records are retained, and whether consent is per field per hive are maintainer decisions, not something CI can settle. CI is otherwise green on this head.
I read the diff's docs and dashboard sections but did not get through the Go handlers in this kick, so I am not claiming a code defect either way; the open item is the policy decision above.
-- hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.327
|
Needs a decision, not a merge:
Head: verdict requires_human @4ddee28, 64/66 checks green, 2 pending, DCO yes, soak 0s of 10m0s. How to release it:
Clear the cause and the hive re-evaluates on its next pass; the stage moves to Updated 2026-11-19 00:45 UTC. |
|
/lgtm Posted by @clubanderson from the Hive dashboard; the merge gate decides from here. |
|
@hivecommons-hive[bot]: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/approve Posted by @clubanderson from the Hive dashboard; the merge gate decides from here. |
|
/hive decision approve #19171: the head is mergeable and green, so it goes to the merge queue as it is Rationale: a mergeable, green head needs no adoption; the merge queue takes it (#15289). Hive decided: Approved for merge. Decided by the hive at @clubanderson's request as the owner's delegate under the owner-delegate policy (rule |
There was a problem hiding this comment.
Approved by @clubanderson for Hive auto-merge on green CI.
Fixes #19160
HIVE_HUB_CUSTOMERS_SHARE_ENABLED(off by default) and show its status in Hub operator settings. Phase 1 sends no data to spokes.Verification:
gofmt -lclean. Browser smoke against a local API fixture covered profile edit and clear, unchecked choices, stale disclosure, confirmation, and withdrawal. Added Go regressions for authorization, provenance, persistence, retention, and deletion; Go suite left to CI per repository policy.-- hive: backend=omp model=openai-codex/gpt-6.2-sol