Skip to content

✨ Betty: plain spec and design requests start a Spek session draft - #19158

Merged
kubestellar-prow[bot] merged 1 commit into
v5from
feat/betty-spec-design-phrases
Nov 18, 2026
Merged

kubestellar-prow[bot] merged 1 commit into
v5from
feat/betty-spec-design-phrases

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Fixes #19157

Maps requests like "start a spec for this", "can you write a spec for the login flow" and "draft a design for X" to the Spek session action. Only when the spec/design word is the object of a request (request lead words, then a verb); statements, questions and negations are ignored. The draft still needs approval. No new config; phrases documented in meetings.md.

🤖 Generated with Claude Code

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • PR Type

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#19101 ✨ Hub: send the confirmation reply for mail sent to a hive with DKIM, behind the signing key (off by default) same files src/docs/meetings.md

@github-actions

Copy link
Copy Markdown
Contributor

Mutation testing

gremlins found 4 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.

File Line Mutation
src/pkg/meetings/betty/actions.go 171 CONDITIONALS_NEGATION
src/pkg/meetings/betty/actions.go 171 CONDITIONALS_NEGATION
src/pkg/meetings/betty/actions.go 213 CONDITIONALS_BOUNDARY
src/pkg/meetings/betty/actions.go 220 CONDITIONALS_BOUNDARY

Verdict: lived (#17349).

@clubanderson clubanderson added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 18, 2026
@clubanderson clubanderson changed the title 🎙️ Betty: plain spec and design requests start a Spek session draft ✨ Betty: plain spec and design requests start a Spek session draft Nov 18, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small false-positive path in the new matcher; otherwise the lead-word gating and the negative tests look sound to me. Static read only, I did not run the tests.

plainSpekRequest (src/pkg/meetings/betty/actions.go:209) accepts any verb in actionVerbs (actions.go:84), which includes keep, take, put, add, note, followed by up to 4 words before spec/design. So "Betty, keep the design simple" or "let's start with the design" (the we should start with the design negative test only passes because we is not in requestLeads) would draft a Spek session. Impact is low since every draft waits for approval, but it is the noise this PR sets out to avoid. Suggest restricting the plain-noun path to a narrower verb set (start, write, draft, create, kick, open, make, as the docs line already states) and rejecting a following with/on directly after the verb, plus a negative test for each.

-- hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.327

@clubanderson clubanderson added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow
kubestellar-prow Bot merged commit 6fecd5f into v5 Nov 18, 2026
109 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the feat/betty-spec-design-phrases branch November 18, 2026 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🎙️ Betty: treat plain 'start a spec' and 'write a design' requests as a Spek session

1 participant