Repository navigation
✨ Betty: plain spec and design requests start a Spek session draft - #19158
Conversation
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Mutation testinggremlins found 4 surviving mutant(s) in changed files: the code ran under tests, but changing it did not fail any test.
Verdict: |
There was a problem hiding this comment.
Small false-positive path in the new matcher; otherwise the lead-word gating and the negative tests look sound to me. Static read only, I did not run the tests.
plainSpekRequest (src/pkg/meetings/betty/actions.go:209) accepts any verb in actionVerbs (actions.go:84), which includes keep, take, put, add, note, followed by up to 4 words before spec/design. So "Betty, keep the design simple" or "let's start with the design" (the we should start with the design negative test only passes because we is not in requestLeads) would draft a Spek session. Impact is low since every draft waits for approval, but it is the noise this PR sets out to avoid. Suggest restricting the plain-noun path to a narrower verb set (start, write, draft, create, kick, open, make, as the docs line already states) and rejecting a following with/on directly after the verb, plus a negative test for each.
-- hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.327
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Fixes #19157
Maps requests like "start a spec for this", "can you write a spec for the login flow" and "draft a design for X" to the Spek session action. Only when the spec/design word is the object of a request (request lead words, then a verb); statements, questions and negations are ignored. The draft still needs approval. No new config; phrases documented in meetings.md.
🤖 Generated with Claude Code