Skip to content

πŸ“– docs: point the TechDocs assessment model at the opt-in analysis fact-check pass - #19150

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
docs/techdocs-factcheck-pointer
Nov 18, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
docs/techdocs-factcheck-pointer

Conversation

@clubanderson

Copy link
Copy Markdown
Member

Refs #19132

Problem

The maintainer feedback in #19132 asks for another agent to do a first review of a drafted TechDocs assessment before the PR is marked ready for review. The hive already ships that as the opt-in review.analysis_factcheck pass (#19074, merged in #19080, documented in src/docs/review-swarm.md). The TechDocs assessment model doc never mentions it, so an operator running that workflow has no pointer to it.

Change

Docs only: one new section in src/docs/workflows/techdocs-assessment.md, "Independent fact-check before a person reviews (optional)", with a config example for a cncf/techdocs hive, how the pass fits the drafting / verify / ready / confirm / approve gates, and a link to the full reference. No code or config behaviour changes.

Verified against

  • src/docs/review-swarm.md section on review.analysis_factcheck: keys, defaults (off, ready_policy: human), "never applies verified", stops once a person reviews.
  • check-api-reference-citations.sh --fix and check-docs-citations.py --fix both pass with no rewrites.

Not covered

Whether the pass is enabled on the TechDocs hive is operator config, not a repo change. Left to the operator, so this does not close the issue.

…ct-check pass

Refs #19132

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 21803b9 into v5 Nov 18, 2026
94 of 95 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the docs/techdocs-factcheck-pointer branch November 18, 2026 21:57
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#19150181b264` sha256:d1ed0d205ea049d14d766d9075e0c727ae13745a3cf0a28b0a93fd686fc090ef β€” download from the dashboard or `hivectl review evidence #19150`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant