Skip to content

πŸ› Accept pull_request in v6 native-queue-policy script - #19115

Closed
clubanderson wants to merge 2 commits into
v6from
fix/nqp-pull-request-event
Closed

clubanderson wants to merge 2 commits into
v6from
fix/nqp-pull-request-event

Conversation

@clubanderson

Copy link
Copy Markdown
Member

The v5 to v6 top-up PR #19100 fails native-queue-policy with Unhandled error: Error: Unsupported policy event.

Cause: v5 moved native-queue-policy.yml from pull_request_target to plain pull_request (GitHub blocks pull_request_target by default on public repos from 2026-12-02). The workflow checks out the trusted base ref to run the script, and for PRs into v6 that is v6's script, which only accepts pull_request_target. The top-up brings the new workflow but the base script cannot be updated by it: a chicken-and-egg.

Fix: port only v5's event acceptance (PR_EVENTS, used for the PR-event branch, the cosmetic label flip check and the policy check source). pull_request_target stays accepted. The workflow file is untouched; the top-up supplies it. Tests cover both events.

Refs #19100

πŸ€– Generated with Claude Code

Refs #19100

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

βœ… Resolved: no conflicting open PRs or same-file overlaps remain against v6.

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 18, 2026
Signed-off-by: Andy Anderson <andy@clubanderson.com>
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Why:

  • the branch conflicts with the base and needs a rebase

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

@clubanderson

Copy link
Copy Markdown
Member Author

Superseded: #19100 merged into v6 carrying v5's full native-queue-policy script, which already accepts pull_request. Nothing left to port.

@clubanderson
clubanderson deleted the fix/nqp-pull-request-event branch November 18, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant