Skip to content

✨ Check the agent's reply names rules captured from review feedback - #19112

Merged
hivecommons-hive[bot] merged 4 commits into
v5from
scanner/fix-19048
Nov 18, 2026
Merged

hivecommons-hive[bot] merged 4 commits into
v5from
scanner/fix-19048

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Rule capture into the knowledge store already landed (#19086), but nothing verified the kicked agent actually acknowledged the captured rules. The sweep now remembers which rule ids a kick carried, and on later passes checks the agent's reply (identified by its handled-ids marker) names each one; if not, or if no reply arrives within 6h, it logs and posts one needs-human note. Closes #19048

-- hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.327

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 18, 2026
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#19102 🐛 Let the agent that opened a PR reply on its review threads CONFLICT src/cmd/hive/review_feedback_wire.go
src/pkg/reviewfeedback/reviewfeedback.go (conflict)
src/pkg/reviewfeedback/reviewfeedback_test.go (conflict)
#18873 🐛 needs-sha: exempt owner/detailed issues, overrideable waiver, visible hold on the row same files src/docs/notifications.md
src/pkg/github/notification_write_sites.go

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 18, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Nov 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Mutation testing

4 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the mutation/acknowledged label to accept this.

File Line Mutation
src/pkg/reviewfeedback/reviewfeedback.go 152 ARITHMETIC_BASE
src/pkg/reviewfeedback/reviewfeedback.go 243 ARITHMETIC_BASE
src/pkg/reviewfeedback/reviewfeedback.go 243 ARITHMETIC_BASE
src/pkg/reviewfeedback/reviewfeedback.go 243 ARITHMETIC_BASE

ℹ️ 2 mutant(s) on added lines were SKIPPED because gremlins v0.6.0 only honours the first lines added lines of each default-context hunk, so non-contiguous edits in one hunk are partly missed. This does not affect the verdict.

File Line Mutation
src/pkg/github/pr_feedback.go 186 CONDITIONALS_NEGATION
src/pkg/github/pr_feedback_replies.go 32 CONDITIONALS_NEGATION

Verdict: uncovered (#17349).

@hivecommons-hive
hivecommons-hive Bot merged commit 55c7686 into v5 Nov 18, 2026
85 of 86 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-19048 branch November 18, 2026 21:16
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#191121a73d24` sha256:b9d9e5df51f686431ca8da63cb814612e89371124981542ac9c253b7a77b267b — download from the dashboard or `hivectl review evidence #19112`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR conflicts-with-open-pr Open PR has a merge conflict with another open PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/L Denotes a PR that changes 100-499 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] ✨ Review-feedback sweep captures reviewer-stated rules into the knowledge store and checks the reply

0 participants