Repository navigation
🐛 Reviewer preflight: follow the repo's own references, report release age without a default verdict, ask for understanding - #19111
Conversation
…lease-age verdict, ask for understanding Rule documents are found from the repository's standard entry files and the links and mentions they contain (bounded depth, byte budget, deterministic order, provenance per document) instead of guessed filename patterns; rule_doc_paths becomes an explicit override. Release age is reported as a fact with no verdict unless the hive config declares min_release_age_days or the repository documents a policy; the 14 day default is removed. The correctness guidance replaces the named failure-mode checks with a short method for understanding the change. Fixes #19106 Signed-off-by: Andy Anderson <andy@clubanderson.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
Mutation testing18 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the
ℹ️ 5 mutant(s) on added lines were SKIPPED because gremlins v0.6.0 only honours the first
Verdict: |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Fixes #19106
Reworks the reviewer preflight from #19075 (#19069) in response to critique from @MikeSpreitzer, whose reviewer comparison motivated it.
What #19075 added, and what changes
rule_doc_pathsis now an explicit override that replaces discovery (a repo's list replaces the hive-wide one). The reviewer still has to cite the rule it applied.min_release_age_daysto 14 and labeled younger versions as "inside the release-age window". There is no universal right threshold, so the default is gone: publish dates are reported as facts ("published 2026-11-16 (2 days ago)") with no verdict, and the reviewer applies a release-age policy only when the hive config declares one (min_release_age_days, hive-wide or per repo) or the repository's own documents state one, quoted. OSV advisory evidence is unchanged; dependency checks stay opt-in.Config. No keys added or removed (golden and settings parity unchanged);
rule_doc_pathsandmin_release_age_dayschange meaning as above, documented insrc/docs/review-swarm.mdandsrc/hive.yaml.example.Tests. Discovery: links, mentions, directory links, github.com links to the same repo, depth bound, byte budget and document cap with provenance on omitted entries, cycles and self links, missing and escaping targets, excluded and unsafe paths, unreadable files and no reader, override replacing discovery. Release age: reported without a verdict when no policy, policy honored when declared (hive or repo), repo can clear a hive policy. Prompt: method present on correctness only, failure-mode checklist gone.
🤖 Generated with Claude Code