Skip to content

πŸ› fix: filter em-dashes in agent GitHub writes through the egress proxy - #19107

Closed
hivecommons-hive[bot] wants to merge 1 commit into
v5from
scanner/fix-19103
Closed

hivecommons-hive[bot] wants to merge 1 commit into
v5from
scanner/fix-19103

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Agent writes made with gh api through the GitHub egress proxy bypassed the shared dash filter, so em-dashes reached GitHub. The shared filter now lives in crux/prosefilter (pkg/prosefilter delegates, API unchanged), and the MITM relay rewrites only the text fields (body, title, message, review comments[].body, GraphQL input body/title) of JSON POST/PUT/PATCH writes, leaving code fences, inline code and blockquotes alone. Content-Length is recomputed; non-JSON bodies and git traffic are untouched; HIVE_PROXY_DASH_FILTER=off disables it (default on). Logs counts only. Not in this PR: the outbound-path inventory and CI guard (items 3 to 5), to be done as follow-ups.

Closes #19103

-- hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.327 requested_by=@clubanderson

…ress proxy

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#19102 πŸ› Let the agent that opened a PR reply on its review threads same files src/crux/proxy/github_proxy_mitm.go
#19110 πŸ› Filter em-dashes on every outbound path, agent proxy writes included CONFLICT src/crux/prosefilter/prosefilter.go (conflict)
src/crux/prosefilter/prosefilter_test.go
src/crux/proxy/github_proxy_mitm.go
src/pkg/prosefilter/emit_guard_test.go
src/pkg/prosefilter/prosefilter.go (conflict)
src/pkg/prosefilter/prosefilter_test.go
#19007 πŸ› fix: strip hop-identity headers and table-test proxy relays same files src/crux/proxy/github_proxy_mitm.go
#19072 πŸ› fix: apply repository scope to GraphQL writes without restricting reads same files src/crux/proxy/github_proxy_mitm.go

@clubanderson

Copy link
Copy Markdown
Member

Superseded by #19110, which carries the same proxy fix (shared filter in crux/prosefilter, pkg/prosefilter delegating, JSON text fields only, git traffic untouched) plus the outbound-path inventory, the remaining unfiltered channels and a CI guard. Closing this one so the two do not conflict or double-merge; #19103 is tracked on #19110.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflicts-with-open-pr Open PR has a merge conflict with another open PR copilot dco-signoff: yes Indicates the PR's author has signed the DCO. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

πŸ› Em-dashes still reach GitHub through agent writes on the egress proxy

1 participant