Repository navigation
π fix: filter em-dashes in agent GitHub writes through the egress proxy - #19107
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
β¦ress proxy Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com> Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Superseded by #19110, which carries the same proxy fix (shared filter in crux/prosefilter, pkg/prosefilter delegating, JSON text fields only, git traffic untouched) plus the outbound-path inventory, the remaining unfiltered channels and a CI guard. Closing this one so the two do not conflict or double-merge; #19103 is tracked on #19110. |
Agent writes made with gh api through the GitHub egress proxy bypassed the shared dash filter, so em-dashes reached GitHub. The shared filter now lives in crux/prosefilter (pkg/prosefilter delegates, API unchanged), and the MITM relay rewrites only the text fields (body, title, message, review comments[].body, GraphQL input body/title) of JSON POST/PUT/PATCH writes, leaving code fences, inline code and blockquotes alone. Content-Length is recomputed; non-JSON bodies and git traffic are untouched; HIVE_PROXY_DASH_FILTER=off disables it (default on). Logs counts only. Not in this PR: the outbound-path inventory and CI guard (items 3 to 5), to be done as follow-ups.
Closes #19103
-- hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.327 requested_by=@clubanderson