Repository navigation
π fix: widen command-safety regex checks - #19092
Merged
Merged
Conversation
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Mutation testing3 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the
Verdict: |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the hivecommons/crux#158 regex widening into the source of truth (src/crux/toolapprove/security.go) so sync can carry it to crux. destructiveCmdRe now also flags dd writing to a raw block device (sd, hd, vd, xvd, nvme) from any input; credentialExfilRe now tolerates quoting,$HOME/$ {HOME}//root, and readers like less, head and base64. Adds TestDefaultSecurityScannerDdBlockDeviceWithoutTextFindings and TestDefaultSecurityScannerCredentialExfilBypasses (bypass cases plus clean-scan cases) and a changelog fragment. Tests were not run locally. Closes #19089
-- hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.327