Skip to content

πŸ› fix: widen command-safety regex checks - #19092

Merged
hivecommons-hive[bot] merged 5 commits into
v5from
scanner/fix-19089
Nov 18, 2026
Merged

hivecommons-hive[bot] merged 5 commits into
v5from
scanner/fix-19089

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Ports the hivecommons/crux#158 regex widening into the source of truth (src/crux/toolapprove/security.go) so sync can carry it to crux. destructiveCmdRe now also flags dd writing to a raw block device (sd, hd, vd, xvd, nvme) from any input; credentialExfilRe now tolerates quoting, $HOME/${HOME}//root, and readers like less, head and base64. Adds TestDefaultSecurityScannerDdBlockDeviceWithoutTextFindings and TestDefaultSecurityScannerCredentialExfilBypasses (bypass cases plus clean-scan cases) and a changelog fragment. Tests were not run locally. Closes #19089

-- hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.327

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Mutation testing

3 mutant(s) in changed files are not reached by any test (NOT COVERED). A maintainer may apply the mutation/acknowledged label to accept this.

File Line Mutation
src/crux/toolapprove/security.go 124 ARITHMETIC_BASE
src/crux/toolapprove/security.go 125 ARITHMETIC_BASE
src/crux/toolapprove/security.go 126 ARITHMETIC_BASE

Verdict: uncovered (#17349).

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 18, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 9685632 into v5 Nov 18, 2026
88 of 89 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-19089 branch November 18, 2026 20:50
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#1909263d285a` sha256:3fbb3385d295fbdb25bf51ce19b0d995f42ec9e3ba2105db360829b8eece8543 β€” download from the dashboard or `hivectl review evidence #19092`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/L Denotes a PR that changes 100-499 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[adjudicator] πŸ› port crux#158 command-safety regex widening into src/crux/toolapprove/security.go

0 participants