Skip to content

🐛 fix: seed scoped reviewer rules into TechDocs assessment kicks - #19079

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:v5from
mendezr:docs/19050-reviewer-rules
Nov 18, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:v5from
mendezr:docs/19050-reviewer-rules

Conversation

@mendezr

@mendezr mendezr commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Closes #19050

  • Identify the upstream TechDocs rubric, curated workflow profiles, and the eligible agent/prompt that perform the assessment.
  • Seed source-linked reviewer rules from Add draft documentation analysis for Hive Commons (pilot) cncf/techdocs#424 into repository knowledge: evidence-based assessment/readiness grading on the documentation domain, and the authoritative project maintainers roster rather than incidental docs ownership files.
  • Run the knowledge primer for workflow-dispatch kicks, which previously bypassed it. Match scope.lanes against the unversioned bound model name in addition to the base agent lane, so rules follow the TechDocs profile even when a different agent fills it and do not reach unrelated quality work.
  • Preserve existing lifecycle, per-agent knowledge scope and byte-cap behavior; document registration and the scope contract for subsequent captured rules.

The review-feedback capture/idempotency/reply-verification path remains the separate scope of #19048 (building on #19029). This change consumes knowledge entries through the existing store/primer API and seeds the already-visible reviewer corrections, so it does not require that unmerged sweep implementation.

Validation

  • Added regression coverage using the shipped criteria plus a source-linked captured-rule fixture, asserting inclusion in a TechDocs kick and exclusion from another workflow and generic quality work.
  • Covered alternate profile agents, model-version changes, base-lane preservation, draft exclusion, per-agent repository scope, byte caps and disabled knowledge.
  • gofmt -l on all changed Go files: clean.
  • Go tests/build/lint and citation guards not run locally, per AGENTS.md; CI is the test verdict.

Operational notes

The knowledge directory must be registered as a vault/git source as documented. Entries remain subject to relevance selection and the configured primer budget. No write permissions, workflow grants or human gates change.

-- hive: backend=pi model=openai/gpt-6.1-sol


🐝 Hive Agent: contributor | SHA: 4e9f94f6c

Seed source-linked assessment criteria from cncf/techdocs#424 and include workflow-scoped knowledge in dispatch kicks without leaking it into unrelated quality work.

Hive-Run: hivecommons#19050
Hive-Plan: reviewer-rules-workflow-injection
Hive-Spec: hivecommons#19050#expected
Signed-off-by: mendezr <mendezr@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#19086 ✨ Capture reviewer-stated rules from review feedback into the hive's knowledge same files src/docs/knowledge-entries.md

@hivecommons-hive

hivecommons-hive Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Ready for a human merge: verdict approved 4e9f94f, 68/68 checks green, DCO yes, soak 10m0s elapsed. Blocked only by role/untrusted (no trusted-author role).

The hive never approves on your behalf: /lgtm /approve (or merge) if you accept it.

Evidence bundle `#190794e9f94f` sha256:f11adb3671326f6d45f62ad940ff35e154af6b8a5c1f44d3a5c6b9ac2f7ced1e — download from the dashboard or `hivectl review evidence #19079`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/lgtm

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/approve

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

@hivecommons-hive[bot]: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Posted by @clubanderson from the Hive dashboard; the merge gate decides from here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

/hive decision approve #19079: the head is mergeable and green, so it goes to the merge queue as it is

Rationale: a mergeable, green head needs no adoption; the merge queue takes it (#15289).

Hive decided: Approved for merge.
Why: Mergeable and green as it is; handed to the merge queue.
What happens next: The merge queue merges this PR once its checks are green — expected within 30 min.
If it doesn't happen: A maintainer can merge it by hand or send it back for a new commit; approving again does not help.

Decided by the hive at @clubanderson's request as the owner's delegate under the owner-delegate policy (rule mergeable-as-is).

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by @clubanderson for Hive auto-merge on green CI.

@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hivecommons-hive[bot]
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow

Copy link
Copy Markdown
Contributor

@hivecommons-hive[bot]: changing LGTM is restricted to collaborators

Details

In response to this:

Approved by @clubanderson for Hive auto-merge on green CI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hivecommons-hive hivecommons-hive Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive queued this PR but could not set the prow/lgtm commit status, so Prow may strip the lgtm label and the auto-merge queue may not hold.

@hivecommons-hive
hivecommons-hive Bot merged commit 4fee149 into hivecommons:v5 Nov 18, 2026
87 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] ✨ Seed reviewer-stated rules into the quality agent's docs-assessment criteria

1 participant