Repository navigation
π contributor lane: no /ok-to-test attempt (and WARN) from an observe-only pass - #19023
Merged
hivecommons-hive[bot] merged 1 commit intoNov 18, 2026
Conversation
requestProwPresubmitsForFork skipped only the merge-request relay. On a repo whose auto-merge is off, the observe-only pass reached it too: its mutation boundary refuses the comment by design, and each pass runs on a fresh engine whose per-head mark is empty, so the refused attempt logged "automerge failed to post ok-to-test workflow approval command" at WARN on every re-evaluation (projectbluefin/server#690: 11 times on one head in 30 minutes). Return before the post in an observe-only pass or the read-only eligibility probe, as the workflow-fence audit comment does (hivecommons#17668). Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On a repo whose auto-merge is off, the hive logged
automerge failed to post ok-to-test workflow approval command β¦ observe-only pass on a repo whose auto-merge is off cannot mutate issue_commentat WARN on every re-evaluation of a non-member fork PR. On projectbluefin/server#690 it fired 11 times on one head between 5:01 and 5:31 AM EST on 11-18, about every three minutes.The contributor lane's Prow
/ok-to-testpath skipped only the merge-request relay. The observe-only pass reached it as well. That pass's mutation boundary refuses every write by design, and each pass runs on a fresh engine whose per-head "already posted" mark is empty, so the refused post was attempted and logged on every pass. This PR returns before the post in an observe-only pass or the read-only eligibility probe. The workflow-fence audit comment already does the same (#17668), and so does the held-runs/ok-to-testpath (workflowApprovalAttention).The fix
requestProwPresubmitsForForkreturns early whenc.observeOnlyorintegrationEligibilityProbe(ctx). A live pass on a repo whose auto-merge is on is unchanged: it still posts once per head.Tests
TestContributorLaneObserveOnlyPassDoesNotPostProwOkToTestruns three observe-only passes, each on a fresh observe-only engine as in production, over the fixture where the live sweep posts once. No comment is posted and nothing is logged at WARN.Locally I ran only
gofmt -l(AGENTS.md bans localgo test/go build/go vet). CI is the test run.Also checked (no change)
The workflow-run auto-approval sweep without Actions write (
POST /actions/runs/{id}/approveneeds Actions: write):PermissionDeniedis carried to later cycles, the CI caption says the runs need approval on GitHub, and π automerge: name held workflow runs and stop base-refreshing themΒ #18945 parks the PR at 085 with the held run ids.π€ Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1