Skip to content

πŸ› contributor lane: no /ok-to-test attempt (and WARN) from an observe-only pass - #19023

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:v6from
Danathar:fix/ok-to-test-observe-only-warn
Nov 18, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:v6from
Danathar:fix/ok-to-test-observe-only-warn

Conversation

@Danathar

Copy link
Copy Markdown
Contributor

Summary

On a repo whose auto-merge is off, the hive logged automerge failed to post ok-to-test workflow approval command … observe-only pass on a repo whose auto-merge is off cannot mutate issue_comment at WARN on every re-evaluation of a non-member fork PR. On projectbluefin/server#690 it fired 11 times on one head between 5:01 and 5:31 AM EST on 11-18, about every three minutes.

The contributor lane's Prow /ok-to-test path skipped only the merge-request relay. The observe-only pass reached it as well. That pass's mutation boundary refuses every write by design, and each pass runs on a fresh engine whose per-head "already posted" mark is empty, so the refused post was attempted and logged on every pass. This PR returns before the post in an observe-only pass or the read-only eligibility probe. The workflow-fence audit comment already does the same (#17668), and so does the held-runs /ok-to-test path (workflowApprovalAttention).

The fix

  • requestProwPresubmitsForFork returns early when c.observeOnly or integrationEligibilityProbe(ctx). A live pass on a repo whose auto-merge is on is unchanged: it still posts once per head.

Tests

  • New: TestContributorLaneObserveOnlyPassDoesNotPostProwOkToTest runs three observe-only passes, each on a fresh observe-only engine as in production, over the fixture where the live sweep posts once. No comment is posted and nothing is logged at WARN.

Locally I ran only gofmt -l (AGENTS.md bans local go test/go build/go vet). CI is the test run.

Also checked (no change)

The workflow-run auto-approval sweep without Actions write (POST /actions/runs/{id}/approve needs Actions: write):

  • A 403 is recorded once per head and never retried for that head. The approval pass is claimed once.
  • PermissionDenied is carried to later cycles, the CI caption says the runs need approval on GitHub, and πŸ› automerge: name held workflow runs and stop base-refreshing themΒ #18945 parks the PR at 085 with the held run ids.
  • The projectbluefin hive's log has no repeated "workflow approval refused" lines since 11-17.

πŸ€– Generated with Claude Code

https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1

requestProwPresubmitsForFork skipped only the merge-request relay. On a
repo whose auto-merge is off, the observe-only pass reached it too: its
mutation boundary refuses the comment by design, and each pass runs on a
fresh engine whose per-head mark is empty, so the refused attempt logged
"automerge failed to post ok-to-test workflow approval command" at WARN on
every re-evaluation (projectbluefin/server#690: 11 times on one head in
30 minutes). Return before the post in an observe-only pass or the
read-only eligibility probe, as the workflow-fence audit comment does
(hivecommons#17668).

Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 18, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 108dcb2 into hivecommons:v6 Nov 18, 2026
81 of 82 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#19023c557036` sha256:7551790f7c7fcfae26240e4b6a9c880927060727f729929559ff39b1380eca7b β€” download from the dashboard or `hivectl review evidence #19023`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant