Repository navigation
🐛 automerge: name held workflow runs and stop base-refreshing them #18945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hivecommons-hive
merged 7 commits into
hivecommons:v6
from
Danathar:fix/held-runs-refresh-and-reason
Nov 18, 2026
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2a7c8fb
fix(automerge): name held workflow runs and stop base-refreshing them
Danathar accb6a3
test(prstage): cover the held-runs reason and cause in their own package
Danathar b0567e6
Merge remote-tracking branch 'origin/v6' into fix/held-runs-refresh-a…
Danathar c957b6a
Merge branch 'v6' into fix/held-runs-refresh-and-reason
hivecommons-hive[bot] 7e45072
Merge branch 'v6' into fix/held-runs-refresh-and-reason
hivecommons-hive[bot] 2ff7a8a
Merge branch 'v6' into fix/held-runs-refresh-and-reason
hivecommons-hive[bot] 875f860
fix(automerge): memoise only the missing checks that justified the up…
Danathar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - A PR whose workflow runs GitHub holds for approval, and that the hive will not approve (an untrusted or fork head, or auto-approval off), now parks at 085 with reason `workflow-approval-required:held-runs:<run ids>` instead of showing an unrelated lane reason such as "author association" or "waiting for a verdict". The approval probe also runs on green heads that are missing a required check (a fork head whose `pull_request_target` check passed), so the missing-check base refresh no longer merges the base into such a PR again and again, and it now updates a PR once per set of missing checks instead of once per check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.