Repository navigation
✨ Customers step E: budgeted GitHub mention search on suggestion accept - #18903
Conversation
Fixes #18884 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. @clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
…QueryMaxLen Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Fixes #18884
Step E of the Customers RFC (#18742): when an owner or read-write user accepts a suggested person, run one budgeted GitHub search for that login so the new profile starts with history beyond what the hive holds.
What it does
mentions:thencommenter:), one page of 30 each, at most 60 results.customers.mention_search.max_requests_per_hour(default 10, capped at 60), rolling hour, unspent requests refunded.customers.mention_search.enabled, envHIVE_CUSTOMERS_MENTION_SEARCH_ENABLED, default OFF (it sends a login to GitHub and the RFC says the section adds no outbound path). Settings, Features toggle added, with the golden file, yaml example, env-vars and operator reference entries.customers_mention_search, low pacing class). It stands down when API budget mode is not normal, the core or search bucket is low, or the secondary-limit slow-start caution window is engaged, and re-checks between the two requests. A rate-limit refusal or pacer shed ends the search.mentioned_in/commented_onedges (sourcegithub_search) ongh:issue:/gh:pr:refs. NewIndex.PutNewwrites only edges the index does not hold, so a search never overwrites the time or source of an edge the poll made; hits are deduplicated per predicate and artefact.Tests
Budget exhaustion (per accept and per hour, including window roll and zero), off switch, quota-low backoff (before and between requests), accept-only call path (sweep makes none, email and refused accepts make none), dedupe, existing-edge preservation, log and result carry ids and counts only, the GitHub client query scoping and error scrubbing, the settings toggle round trip and markup.
Not run locally per repo process (no go build/test/vet); gofmt checked, docs and API-reference citation scripts pass. CI is the verdict.
🤖 Generated with Claude Code