Repository navigation
🐛 contribute: offer wrong_base only with a vN base; a park keeps the agent's reason #18841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
hivecommons-hive
merged 3 commits into
hivecommons:v6
from
Danathar:fix/wrong-base-no-release-line
Nov 18, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - A contributor task in a repository with no `vN` release branches (one on `main` / `testing` / `stable`) is no longer offered the `wrong_base` verdict, which could only ever park the issue at `stage/045-needs-decision`; the agent asks in the decision form instead. A `wrong_base` verdict that does park now keeps the agent's own reason: its one park note quotes it (sanitized and capped, never used as a branch), the generic needs-decision question is no longer posted beside it, and the log and verdict record carry it. The hub still re-dispatches only to a validated `vN` branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gate is
baseBranch != "", but the hub only re-dispatches to avNbranch (normalizeWrongBaseTarget).taskBaseBranchForIssuereturns the hive's ownhubBranchunchecked for hivecommons/hive, so a non-vNbuild branch would still be offeredwrong_baseand park. ConsiderisReleaseLine(strings.ToLower(strings.TrimSpace(baseBranch)))to match the comment and docs.