Repository navigation
π blocked sweep: wait on every blocked-on marker, not just the first - #18840
Conversation
One comment (or the body) may name several blockers. The sweep read only the first marker and lifted blocked when it settled, while another named blocker was still open (projectbluefin/testsuite#1023). Every marker of either form in the newest marker-bearing comment, else the body, now counts: blocked comes off once all are settled, with one note naming them; a re-target of one carries the others' markers forward. A single marker keeps the existing path. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The re-target note for several blockers is a notification-capable write carrying the machine-read blocked-on markers, like blockedSuccessorRetargetIssue; class it protocol_command in notificationWriteSites and the notifications doc table so TestNotificationWriteSitesInventory passes. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
|
@Danathar this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (8 waiting): fixes are handed out before new work as soon as you have capacity. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Summary
When one blocked-on comment (or the issue body) names two or more blockers, the blocked sweep read only the first marker. Once that blocker closed, it removed
blockedand said "This issue is actionable again", even though another named blocker was still open.With this change the sweep reads every marker, PR and issue forms alike, and lifts
blockedonly once all of them are settled. A single marker behaves exactly as before.What happened
Seen on projectbluefin/testsuite#1023 (Eastern times):
blockedwas added with one comment holding two markers:issue=projectbluefin/utah#1198andissue=projectbluefin/testsuite#1215.blockedwith "Unblocked: selinux: ublue-booted-image runs bootc status from a script, so bootc's capability probe logs two chcon AVC denials every bootΒ projectbluefin/utah#1198 is closed. This issue is actionable again." testsuite#1215 was still open, and the issue has no native "blocked by" links.stage/010-actionable, thenstage/stalled, while it was really still waiting on feat: scheduler coverage 87.7% β multi-agent message testsΒ #1215.Cause
blockedSweepComments(issue_blocked.go:1098-1124at d058541) keeps the first marker of the newest marker-bearing comment.ParseBlockedOnMarkerandparseBlockedOnIssueMarkereach return one match.pr=and anissue=marker ignored the issue blocker.blockedFilterReason) also names only the first marker.reconcileBlockedOnIssueand the PR branch ofreconcileBlockedTargetsthen settle that one target.The PR side already does this right:
blockedPRMarkedTargets(#17689) reads every marker and lifts only once all have settled.What changed
Reading markers (
issue_blocked.go)parseBlockedOnRefsreturns every distinct marker of both forms, in order.SweepBlockedIssues, and the enumeration row via a newRepoWorkIssue.BlockedOn) record the full list only when it names more than one blocker.Settling (
reconcileBlockedOnAll)blockedIssueSuccessorOf, the same lookup and grace the single-issue path uses).blockedstays, onlyhelp wantedis stripped, and no note is posted.project.issue_filteradmission like the PR note.Re-target
gate_comment), like the issue successor re-target.Docs: the
blockedrow and section inlabels-and-control-signals/reference.md, plus a changelog fragment.Not in this PR
IsBlockedIssueReason,ParseBlockedOnReasonand the dashboard caption are unchanged.stage/stalleddwell policy are out of scope.blocked on owner/repo#N(the PR form, withoutissue). If a later pass's comment budget skips that issue, the sweep looks the blocker up as a PR. This affects single markers too and is left for its own change.Tests
TestParseBlockedOnRefs:BlockedOn;BlockedOnround trip, and the prose list.TestReconcileBlockedIssuesWaitsOnEveryMarker, next toTestReconcileBlockedIssuesBlockedOnIssue:blockedstays,help wantedis stripped, no note;pr=marker beside an openissue=marker: both are read, and the block stays;blockedSuccessorFakenow also serves/pulls/Nfor the PR-marker case.Only
gofmt -lwas run locally (AGENTS.md bans localgo test/go build/go vet); CI runs the tests.π€ Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1