Repository navigation
π contribute: an unverified already-done verdict no longer leaves hive/already-done on the issue - #18836
Conversation
β¦ label on The relay applied hive/already-done on reason text alone; the hub then commented that nothing could be verified and the issue is not labelled, but left the relay's label on (projectbluefin/utah-packages#1175). Relay: markIssueAlreadyDone labels only when the reason cites a PR, a PR URL or a commit. Hub: the unverified path removes a hive/already-done the hive added since the task was dispatched; a person's label stays. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Style review at 9669f02: approve. Conventions followed; one advisory note on duplicated event-pagination code (inline).
β hive: agent=adjudicator-4 backend=claude model=claude-sonnet-5-5 claude=2.1.326
| events, resp, err := c.client.Issues.ListIssueEvents(ctx, owner, name, number, opts) | ||
| if err != nil { | ||
| return false, err | ||
| } |
There was a problem hiding this comment.
Advisory (style): this paginated ListIssueEvents loop duplicates latestLabeledAt earlier in this file (lines 66-84), and the label-presence scan above it duplicates issueHasLabel. Consider a shared helper such as latestLabeledBy(ctx, owner, name, number, label) (at time.Time, actor string, err error) that both callers use. Not blocking.
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Review findings from Docs-currency: the contributor-relay.md row and changelog fragment match the new behavior. One advisory wording fix (inline): the row should mention that a bare Findings not on a changed line
Review findings from Intent alignment: the diff does what the title and body say. The relay now labels only when the reason cites a ref ( One advisory gap, not blocking.
The docs row now says a verdict that fails verification never gets the label. That is slightly stronger than the code for the open-PR case. If you want to close it, remove the label in the non-merged branch with the same |
Summary
When a contributor says an issue is "already resolved" without citing a PR or commit, the contributor relay puts
hive/already-doneon the issue anyway. Seconds later the hub comments that nothing could be verified, "so it is not labelledhive/already-done", but it leaves the relay's label on. The issue then sits out of the offer queue as if it were verified done, with no maintainer check.With this change:
What happened
Seen on projectbluefin/utah-packages#1175 (11-16, Eastern time):
hivecommons-hive[bot]addedhive/already-done. This was the relay, using the task credential.no_work_neededverdict with reason "external mirror outage already resolved (HTTP 200". The reason has no PR and no SHA.hive/already-done."The docs promise the opposite (
contributor-relay.md, already-done label row): "A verdict with no cited PR/commit, or one that fails verification, never gets this label."Cause
markIssueAlreadyDoneruns wheneverisAlreadyDoneNoWorkis true. That only needs the reason to matchALREADY_DONE_TEXT_RE("already resolved", "no-op", β¦). Its only other check is for open sub-issues.markAlreadyDoneUnverified/noteAlreadyDoneUnverified). It changed only the hub, so it never stops the relay from applying the label, and the hub's unverified path posts the comment and books the hold without removing it.What changed
Relay (
bin/contributor-relay.js)alreadyDoneCitesRef(reason). It is true when the reason carries:merged PR #Nor a commit SHA), or#N, ormarkIssueAlreadyDonereturns early without one, before any GitHub read. It logs one line saying why.Hub
New
Client.RemoveHiveLabelAddedSince(pkg/github/done_verdict_labels.go). It removes the label only when all of these hold:labeledevent is by one of the hive's own identities (IsHiveAuthorLogin);It reads issue events only when the label is present. A zero dispatch time removes nothing. The removal goes through
RemoveLabelsFreshwith a// writeback:solicitednote.markAlreadyDoneUnverifiednow takes the task's dispatch time. It removes the label before posting the comment, so the hold is still booked after the hive's own activity, as before.The verified path (
markAlreadyDoneIssue), the hold length and the comment wording are unchanged. The wording is now true.Docs and changelog
contributor-relay.mdalready-done row now says what each side does.Not in this PR
[shared-ci]tracker should do when its cause clears.Tests
bin/contributor-relay.test.js:merged PR #532and a/pull/532URL still label;#12, sub-issue guards) are unchanged and pass.contribute_verdict_settle_ghclient_test.go: the unverified path, run through the real GitHub client:All cases still post the unverified comment and add no label.
Existing callers of
markAlreadyDoneUnverifiedin the tests now pass a zero dispatch time.I ran the full relay test file locally on node 26. It has 78 failures, the same 78 as on clean v6, all environment-related; every already-done test passes. Only
gofmt -lwas run for Go (AGENTS.md bans localgo test/go build/go vet). CI is the test run.π€ Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1