Repository navigation
π governor-pr-models-ui test: one extractFunction, so the per-model PR list test compiles - #18831
Merged
hivecommons-hive[bot] merged 1 commit intoNov 17, 2026
Conversation
Two PRs that merged into v5 each added a top-level extractFunction to this file. Function hoisting makes the later one win, and it slices from 'function', dropping 'async' from loadGovernorPRModelPRs, so the per-model PR list test fails to compile (await outside an async function) and server-tests is red on every v5 PR. Keep the first helper, which keeps 'async'; the per-repository test's use is the same. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. Evidence bundle `#18831b62b4e6` sha256:c87ac918a20eaa03cce7a8d5af4ff44dc743178aacd11cc0b37728140ae3dc5a β download from the dashboard or `hivectl review evidence #18831`.merged by Hive trusted-author auto-merge: author |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server-testsis red on every open v5 PR becausedashboard/test/governor-pr-models-ui.test.jsno longer compiles one of its tests. This removes a duplicate helper in that file; no product code changes.Cause
Two PRs merged into v5 today each added a top-level
function extractFunction(name)to the same test file:async.function.Function declarations hoist, so the later one wins for the whole file. The per-model PR list test then extracts
loadGovernorPRModelPRswithoutasync, andvm.runInContextthrowsSyntaxError: await is only valid in async functions.CI output:
not ok 38 - Opening a model row requests model=β¦ and lists its PRs with GitHub linksin theserver-testsjob (Dashboard Lint).What changed
extractFunction. The remaining one handles both callers; the per-repository test only extractsgovernorPRModelSliceDetail, which is not async, so its result is unchanged.Tests
node --test dashboard/test/governor-pr-models-ui.test.js: 5/5 pass locally (default env andTZ=UTC LANG=C). Before the change the per-model PR list test failed with the same SyntaxError as CI.π€ Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1