Repository navigation
✨ dashboard: merge banner shows when it merged; Time format option - #18829
hivecommons-hive[bot] merged 4 commits into
Conversation
The merge banner's time sat at the end of the one-line title, where a long title's ellipsis hid it, and it was when the tab noticed the merge. It now rides the head line as date and time in the Display timezone, from the ledger's merged_at when known. Settings -> Appearance gains Time format (browser locale, 12-hour, 24-hour), applied in the shared date formatter. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Danathar this PR is back in your court ( Failing checks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (7 waiting): fixes are handed out before new work as soon as you have capacity. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
dashboardDateFormatter now reads dashboardClockPreference, so the idle-work node harness that lifts the real formatter needs that function and DASHBOARD_CLOCK_STORAGE_KEY too; without them it threw ReferenceError and TestDashboardIdleWork failed. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Picks up the governor-pr-models-ui test fix so server-tests runs against a base whose test file compiles. Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. Evidence bundle `#18829e8f3c0e` sha256:b44a5db87a84dc6747cb345835b5f1fc5bc0c41c1f623c2683d7599d1b34c28a — download from the dashboard or `hivectl review evidence #18829`.merged by Hive trusted-author auto-merge: author |
Summary
The merge banners at the bottom right of the Activity monitor now show when the PR merged, as a date and local time on the top line:
Settings → Appearance also gets a Time format choice next to Display timezone: browser locale (default), 12-hour, or 24-hour. It applies to every time the dashboard shows.
Why
Each banner already carried a time, but in practice nobody could see it:
merged_at.17:42, in 24-hour form.What changed
Merge banner (
tracker-merged.js,tracker.css)<time>element whosedatetimeis the ISO instant. The format isformatDashboardDateTime's usual "11/17 4:12 PM EST", so it follows Display timezone and Time format.merged_atwhen the ledger lists the PR. Otherwise it is when the tab noticed the merge, as before.Time format option (
refresh.js,config-tabs.js)localStorage(hive-dashboard-clock-format), like Display timezone.dashboardDateFormatterapplies it to any format that has an hour:hourCycle: 'h23', so midnight is 00:00, never 24:00.hour12.Docs and changelog
architecture.md(Display timezone paragraph) andactivity-monitor.md(banner description).Not in this PR
The Hive vs human trend on v5 shows no clock times, so there is nothing to change on this branch. On v6 its axis labels and hover ranges use the browser's 24-hour clock directly. A small v6 change can move them onto
formatDashboardDateTimeonce this option is forward ported.Tests
dashboard_clock_format_test.go:jsFunc's UTC stand-ins, in America/New_York with the locale pinned to en-US. It checks the default format, 24-hour (including midnight), 12-hour overriding a caller's 24-hour cycle, an unknown stored value being ignored, and the banner'swhen,metaand hover text.stage_tracker_cues_test.go:<time>whosedatetimeis the ledger record'smerged_at(one minute before the tab noticed it);The node part of the new test was run locally under four timezone and locale pairs (UTC/C, Asia/Tokyo/en_GB, America/Los_Angeles/de_DE, America/New_York/en_US), and
stage_tracker_merge_banner_countdown.test.jspasses against the new bundle. Onlygofmt -lwas run for Go (AGENTS.md bans localgo test/go build/go vet); CI runs the Go tests.static/index.htmlwas regenerated fromstatic-src/.🤖 Generated with Claude Code
https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1