Skip to content

✨ dashboard: merge banner shows when it merged; Time format option - #18829

Merged
hivecommons-hive[bot] merged 4 commits into
hivecommons:v5from
Danathar:feat/local-time-merge-banner-trend
Nov 17, 2026
Merged

hivecommons-hive[bot] merged 4 commits into
hivecommons:v5from
Danathar:feat/local-time-merge-banner-trend

Conversation

@Danathar

Copy link
Copy Markdown
Contributor

Summary

The merge banners at the bottom right of the Activity monitor now show when the PR merged, as a date and local time on the top line:

✓ hive #18810 merged by 🐝 hive · 11/17 4:12 PM EST

Settings → Appearance also gets a Time format choice next to Display timezone: browser locale (default), 12-hour, or 24-hour. It applies to every time the dashboard shows.

Why

Each banner already carried a time, but in practice nobody could see it:

  • It was clipped. The time was the last part of the title line ("fix: enable bulk delegation… (adopted, by hive, 17:42)"). That line never wraps, so on a desktop any real PR title pushed the time past the ellipsis. With five banners stacked, none showed a time.
  • It was the wrong time. The banner used the moment the browser tab noticed the merge, not when it merged. Every merge found in one refresh got the same time. It even overrode the ledger's real merged_at.
  • It had no date. It showed only 17:42, in 24-hour form.

What changed

Merge banner (tracker-merged.js, tracker.css)

  • The date and time move to the head line, after "merged by …", in a muted <time> element whose datetime is the ISO instant. The format is formatDashboardDateTime's usual "11/17 4:12 PM EST", so it follows Display timezone and Time format.
  • The time is the ledger's merged_at when the ledger lists the PR. Otherwise it is when the tab noticed the merge, as before.
  • The title line keeps "(lane, by …)" without the time. The hover title gains "· merged ".

Time format option (refresh.js, config-tabs.js)

  • Saved per browser in localStorage (hive-dashboard-clock-format), like Display timezone.
  • dashboardDateFormatter applies it to any format that has an hour:
    • 24-hour uses hourCycle: 'h23', so midnight is 00:00, never 24:00.
    • 12-hour forces hour12.
  • The default, browser locale, changes nothing. Every existing view keeps its current format until someone picks an option.
  • The navbar clock goes through the same formatter, so it follows the choice too.

Docs and changelog

  • architecture.md (Display timezone paragraph) and activity-monitor.md (banner description).
  • A changelog fragment.

Not in this PR

The Hive vs human trend on v5 shows no clock times, so there is nothing to change on this branch. On v6 its axis labels and hover ranges use the browser's 24-hour clock directly. A small v6 change can move them onto formatDashboardDateTime once this option is forward ported.

Tests

  • New dashboard_clock_format_test.go:
    • checks the settings control exists;
    • runs the shipped date helpers, not jsFunc's UTC stand-ins, in America/New_York with the locale pinned to en-US. It checks the default format, 24-hour (including midnight), 12-hour overriding a caller's 24-hour cycle, an unknown stored value being ignored, and the banner's when, meta and hover text.
  • stage_tracker_cues_test.go:
    • the banner head carries a <time> whose datetime is the ledger record's merged_at (one minute before the tab noticed it);
    • the title line reads "(hive, by hive)".

The node part of the new test was run locally under four timezone and locale pairs (UTC/C, Asia/Tokyo/en_GB, America/Los_Angeles/de_DE, America/New_York/en_US), and stage_tracker_merge_banner_countdown.test.js passes against the new bundle. Only gofmt -l was run for Go (AGENTS.md bans local go test/go build/go vet); CI runs the Go tests. static/index.html was regenerated from static-src/.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1

The merge banner's time sat at the end of the one-line title, where a
long title's ellipsis hid it, and it was when the tab noticed the
merge. It now rides the head line as date and time in the Display
timezone, from the ledger's merged_at when known.

Settings -> Appearance gains Time format (browser locale, 12-hour,
24-hour), applied in the shared date formatter.

Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 17, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 17, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

@Danathar this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Failing checks:

  • server-tests

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (7 waiting): fixes are handed out before new work as soon as you have capacity.

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18782 ✨ Governor PRs by model: split closed-unmerged PRs into superseded, duplicate and other same files src/pkg/dashboard/static/index.html
#18780 ✨ Governor PRs by model: what each model's PRs cost the hive to review same files src/pkg/dashboard/static/index.html

Danathar and others added 3 commits November 17, 2026 17:16
dashboardDateFormatter now reads dashboardClockPreference, so the
idle-work node harness that lifts the real formatter needs that
function and DASHBOARD_CLOCK_STORAGE_KEY too; without them it threw
ReferenceError and TestDashboardIdleWork failed.

Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
Picks up the governor-pr-models-ui test fix so server-tests runs
against a base whose test file compiles.

Signed-off-by: Danathar <6772335+Danathar@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BQYnPGFJx81c8JXR3o1sg1
@hivecommons-hive
hivecommons-hive Bot merged commit 1ff57d9 into hivecommons:v5 Nov 17, 2026
74 checks passed
@hivecommons-hive

hivecommons-hive Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#18829e8f3c0e` sha256:b44a5db87a84dc6747cb345835b5f1fc5bc0c41c1f623c2683d7599d1b34c28a — download from the dashboard or `hivectl review evidence #18829`.

merged by Hive trusted-author auto-merge: author Danathar holds role owner and GitHub permission maintain on repo; CI green at e8f3c0e.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant