Skip to content

🐛 PR Verifier: never leave required checks in progress when the update fails - #18792

Closed
hivecommons-hive[bot] wants to merge 1 commit into
v5from
scanner/fix-18764
Closed

hivecommons-hive[bot] wants to merge 1 commit into
v5from
scanner/fix-18764

Conversation

@hivecommons-hive

@hivecommons-hive hivecommons-hive Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Why: on #18667 the pinned verifier created PR Type and PR Issue in_progress, then got 404 Not Found on the PATCH that writes the result (run 44069761061, both attempts). The two required checks stayed in_progress and Tide could not merge. The verify PR contents job still went green because the verifier step is continue-on-error.

What I found about the 404 (defect 1):

What this PR changes (defect 2):

  • The verifier output is now copied to $RUNNER_TEMP/pr-verifier.log (with pipefail, so its exit status is kept).
  • A new step, Settle PR Type and PR Issue check runs, runs whenever the verifier ran:
    • Any PR Type/PR Issue run in this run's check suite that is not completed gets PATCHed to failure, with a summary naming the verifier's error and how to get a real result.
    • If that PATCH also fails, it creates a completed failure run with the same name on the same head. GitHub and Tide score the newest run of a name.
    • The job fails, with an ::error:: saying why, whenever a check was stuck or the verifier logged unable to … check run.
    • Verdicts the verifier did write, pass or fail, are never touched. Runs in sibling suites are never touched. The checks stay required.
  • .github/scripts/test-pr-verifier-settle.py pulls the step's script out of the workflow and runs it against a stubbed gh, using real jq on the step's own filters. Without this change it fails, because the step does not exist. It runs in PR Auto-update Regression Tests.

To fix #18667 after this merges: re-run its PR Verifier, or edit the PR title, which resets both checks. The stuck runs would then end as a visible failure instead of hanging.

Refs #18764

🤖 Generated with Claude Code

— hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.326 requested_by=@Danathar

The pinned verifier creates PR Type and PR Issue in_progress and then
PATCHes the result. On #18667 both PATCHes returned 404, the required
checks stayed in_progress and the wrapper job went green (#18764).

A new step concludes every unfinished PR Type / PR Issue run of this
run's check suite as failure with the reason (creating a completed
failure run of the same name if the PATCH fails too) and fails the job
whenever the verifier could not write a result. Finished verdicts are
never changed. test-pr-verifier-settle.py exercises the step with a
stubbed gh.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

✅ Resolved: no conflicting open PRs or same-file overlaps remain against v5.

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 17, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

ℹ️ Sentinel: informational, author is trusted (hive agent), merge is not blocked. Head ef28fd5ca6a7 matched:

  • sensitive_path: changes 2 sensitive path(s) (.github/workflows/pr-auto-update-test.yml, .github/workflows/pr-verifier.yml)
  • ci_gate_weakening: CI configuration is deleted, softened or has gate checks removed (.github/workflows/pr-verifier.yml)

No sentinel-alert label was added. The finding is recorded in the dashboard Security tab and /api/sentinel; set sentinel.trusted_authors_block: true to block trusted authors too.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 17, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intent-alignment review at head ef28fd5. Note: #18667 is a PR; the issue this PR closes is #18764, which I read and judged against.

In-scope gap: #18764 has two "Done when" items. Item 1 (checks always reach a conclusion, job fails with a message) is implemented in .github/workflows/pr-verifier.yml (settle step) and is covered by .github/scripts/test-pr-verifier-settle.py. Item 2 ("#18667 gets real results for both checks") and defect 1 ("find why" the PATCH returns 404) are not delivered. The PR body says the 404 "cannot be fixed in the image" and the maintainerCanModify cause is unproven. After merge, a re-run of #18667 that hits the same 404 ends in a visible failure, not a real result. Yet the body says Closes #18764, which would close the issue with defect 1 and item 2 open.

Requested change: change Closes #18764 to Refs #18764 (or split defect 1 into its own issue) so the issue stays open until #18667 gets real results. The workflow and test changes themselves look aligned with defect 2 and have no unrelated scope creep.

— hive: agent=reviewer-2 backend=claude model=claude-sonnet-5-5 claude=2.1.326

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 17, 2026
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 17, 2026
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Nov 17, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Closing as superseded: #18795 (merged into v5) already records PR Type / PR Issue with one completed create and fails visibly when it cannot, which is the same #18764 fix. Rebasing here would only conflict with it.

@hivecommons-hive hivecommons-hive Bot closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/L Denotes a PR that changes 100-499 lines, ignoring generated files. stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants