Repository navigation
🐛 Activity monitor: one rule for the human-gate pill and its verbs; name the real blocker - #18772
Conversation
…ame the real blocker The gate pill lit 'Needs human · review' from the cached reviewer verdict for the head while its verbs acted only on a PR the hive had parked on a person, so a PR whose sign-off a person had already approved kept offering Approve / Request changes / Let hive decide and every click answered 'nothing to act on' (#18667). - stage_tracker_gate.go: one predicate for the reasons a person is owed, the verbs that act, and what the item waits on when nothing is owed; carried in the payload as human_gate (rows and linked PRs). - tracker-gate-truth.js: the pill and runRowAction share one mapping; a verb is drawn only where the action has something to act on. The review reason and a bare needs_human stand only while the row is parked. - Required checks queued or in progress past HIVE_TRACKER_CHECK_STUCK_AFTER (2h) are named as stuck, not running. - A stale click says what the item is waiting on and re-reads the tracker. Fixes #18769 Signed-off-by: Andy Anderson <andy@clubanderson.com>
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. clubanderson this PR is held at Failing checks:
Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path. |
…o waiting pill on inert rows Signed-off-by: Andy Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Fixes #18769
What was wrong
A tracker row showed Needs human · review with Approve, Request changes… and Let hive decide, and the click answered nothing to act on — #18667 is not waiting on that decision.
The pill and the action read two different sources:
stageTrackerHumanGateReasons) litreviewwhenever the cached reviewer verdict for the head wasrequires_human(review_activity.state == human_decision);runRowAction->stageTrackerDecisionTarget/stageTrackerPRParked) acted only on a PR the hive had actually parked on a person.A verdict never changes for a head. Once a person approved it the PR left 085, the action had no target, and the pill stayed. The same split made Needs human · decision appear on triage-needed and author-owned rows (flagged only by
needs_human), and put Let hive decide on hold / sentinel pills of rows that are not parked.What changed
stage_tracker_gate.gocomputes, per row, the reasons a person is owed something now, the verbs that would act, and what the item waits on when nothing is owed. The payload carries it ashuman_gate(rows and the linked PRs that mirror them). In the page,tracker-gate-truth.jsgives the pill andrunRowActionone shared mapping (stageTrackerGateTargets/stageTrackerGateAccepts): a verb is drawn only where the action has something to act on.needs_humanstand only while the row is parked. An answered sign-off shows a passive Approved by @login · waiting on … pill; triage and author-owned rows keep their own lead (Accept triage, Adopt).HIVE_TRACKER_CHECK_STUCK_AFTER(default2h) is listed inci_activity.checks_stuckand reads stuck, not running; when every pending check is stuck the caption isCI stuck · …and the track stops pulsing.Server endpoints are unchanged: they validate against live GitHub state as before. The refusal in the report came from the page's own target mapping.
Tests
testdata/gate_states.json: one table of gate states, run by bothstage_tracker_gate_test.go(server rule) andstage_tracker_gate_truth.test.js(the shipped pill renderer and action mapping). Both assert offered <=> accepted for every verb.Docs: activity monitor (Settling a human gate), API reference (
human_gate,checks_stuck), env-var reference. Changelog fragment included.🤖 Generated with Claude Code