Skip to content

🌱 chore: top up v6 from v5 (2026-11-17, second pass) - #18689

Merged
kubestellar-prow[bot] merged 61 commits into
v6from
topup/v5-to-v6-202611171235
Nov 17, 2026
Merged

kubestellar-prow[bot] merged 61 commits into
v6from
topup/v5-to-v6-202611171235

Conversation

@clubanderson

@clubanderson clubanderson commented Nov 17, 2026 •

Copy link
Copy Markdown
Member

This PR merges origin/v5 into v6 (4ab9ba0, v6.42.1) as three signed merge commits plus one DCO remediation commit. The first carries v5 through ff268e2 (#18673); the second carries #18687 and #18695; the third carries the v5.298.2 release gate, all of which landed while the branch was being resolved. The v5 range topped up is b2a1c149f..ff8989049 (50 commits, v5.292.0 → v5.298.2 plus #18673). After it lands, origin/v5 is an ancestor of v6 again (checked with git merge-base --is-ancestor). This is the second top-up today, after #18620; the automated v6-topup.yml run did not open a PR for this range (conflicts outside the resolver's known patterns), so I carried it by hand.

cc @Danathar: this carries #18673 (Copilot login reaches running agents without a restart, follow-up to #18445) to v6.

What it carries

Everything on v5 since #18619, including:

Conflicts and how they were resolved

Area Resolution
cmd/hive/main_eval_cycle.go v6 had moved the kick-dispatch block (snapshot-before-dispatch through persistReviewDispatchState) later in runEvalCycle; v5's #18571 edited the old position. Dropped v5's stale copy and ported its three edits into v6's block by hand: onDeferred and onFailed release a workflow dispatch for the kick, onDelivered records it and audits workflow-dispatch. The withholdWorkflowOwnedForKicks and planWorkflowDispatchKicks hooks upstream merged on their own. gofmt -l is clean.
pkg/fleetreport/runtime.go Union of the class constants: v6's five (github_app_*_permission_missing, hub_heartbeat_rejected_unprovisioned, proxy_plain_forward_failed, agent_lifecycle_repeated) plus v5's spek_stream_unavailable.
static-src/js/tracker-actions.js, static/index.html STAGE_TRACKER_ACTING_CAPTIONS is the union: v6's blocker:handoff plus v5's wf-dispatch. index.html is rebuilt as the byte-exact concatenation of static-src/manifest.txt (the resolver's recipe).
dashboard/openapi.json Kept v6's side (/api/feedback/nps/issue, /api/github/mentions/webhook) and added v5's /api/workflows/dispatch path structurally (parsed, inserted before /api/workflows/enabled, re-serialized; the file round-trips byte-identically). Every v6 path is unchanged, every v5-only path (/api/companion/*, /api/meetings/clear-finished, /api/meetings/schedule/{eid}, /api/workflows/dispatch) matches v5.
docs/api-reference/{auth,configuration,packs-and-acmm}.md Kept v6's row order (v6 had regrouped the configuration rows); the sides differed only in line citations. v5's /api/workflows/dispatch row merged on its own. check-api-reference-citations.sh --fix rewrote 15 drifted citations; check-docs-citations.py verifies 2162 references clean.
CHANGELOG.md The resolver's union, v6 sections first, then v5.293.0 through v5.298.1. Both sides' changelog.d/ fragments are kept.
.github/scripts/integration-governance.cjs TRUSTED_SCRIPTS_TREE re-pinned to the merged src/scripts tree, f2fe6fe1e63a7e7ba9ce01f7c6be174effdcb7fa (v5's #18617 and #18634 changed mutation-report.sh and its test).

The DCO remediation commit covers f444b4f (#18647) and 3d8d438 (#18648): v5 squash commits authored as Andy Anderson <andy@clubanderson.com> whose only sign-offs are hive-release[bot] and the clubanderson noreply address. They are v5 history and are not rewritten.

Nothing was built or tested locally. CI is the gate.

🤖 Generated with Claude Code

clubanderson and others added 30 commits November 17, 2026 03:33
…'s reason (#18600)

* 🐛 meetings: log every failed meetings call and keep a failed approval's reason

A Quorum refusal of a Discord join (blocked: no permission to connect)
was answered as 502 with no log line, and the hosted ingress replaced the
body with its generic page, so the owner saw 'hive unavailable' and the
spoke log said nothing. Every meetings call failure is now logged with
method, path, status and error (Warn for 5xx, Info for caller mistakes),
and ApproveRequest records the failure reason on the still-open request.

Refs #18598

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🐛 meetings: a blocked Discord join names the bot's permissions, and a failed approval shows on the request

The panel read every blocked meeting as 'The meeting refused a guest bot',
which is a Meet/Teams lobby refusal; on Discord blocked means the bot's
role lacks View Channel, Connect or Speak on the voice channel. The join
request row now also renders the reason a failed approval saved.

Refs #18598

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 📖 api-reference: re-point meetings route citations after the import shift

Refs #18598

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>
…p bot (#18610)

* ✨ remote items: follow up on items the hive opened as its App bot

With project.remote_write_identity a write-tier reference repo can write as
the App bot, but the own-item poller listed creator=<owner> under the
owner token only, so feedback on bot-opened issues and PRs never reached
the agent.

- remoteitems: RunTargets takes (repo, login) pairs; each repo is listed and
  its feedback filtered under its own login. Run keeps its signature as a
  one-login wrapper.
- github.RemoteItemsFetcher: optional TokenFor picks the read token per
  repo and is authoritative when set (no fallback to the owner token).
- cmd/hive: every write-tier repo is watched under its CredentialLogin and
  read with the token the proxy injects on its writes (scoped bot token,
  owner token or write_token_file).

Refs #18516

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🐛 remote items: fix the per-repo login test's use of Store.Items

Store.Items returns a slice; build the tracked set from Item.Key.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 📖 two-lane doc: the own-item follow-up covers bot-opened items too

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>
…assifier outage (#18618)

A fail-closed kick block was always logged as "ioscan fail-closed blocked
kick", which the fleet report classes as ioscan_classifier_unavailable. But
the kick is also withheld when untrusted issue/PR text trips the injection
policy (a Critical finding or a classifier block verdict) while the
classifier is answering: the defense working as designed, not an outage.
The #18459 report carried no classifier_error, i.e. exactly that case.

warnBlockedKick now keeps the fleet-reported wording (with classifier_error
and fix) only when the classifier is failing, and otherwise logs "ioscan
fail-closed withheld kick on an injection finding", listed in
fleetreport.IsBenignMessage. The held-PR coordination path goes through the
same helper, so it now also names the classifier error on an outage.

Closes #18459

Hive-Run: #18459
Hive-Plan: selfreport-ioscan_classifier_unavailable
Hive-Spec: fleet-report#ioscan_classifier_unavailable
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
…8609)

`fetch-depth: 0` makes actions/checkout fetch every branch and tag. That
took 17-35s normally and on #18482 (run 43960382195) hung for the whole
5-minute job budget, failing the required "Sign-off survives the squash"
context before the check ran.

Check out the head shallowly, then fetch the head, base and default-branch
histories in full (unshallow), with a 60s per-attempt stall timeout and
three attempts. Picks up the fix a contributor reverted out of #18482 as
unrelated to that PR, plus the stall retry and post-fetch assertions.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
…spatch once) (#18571)

* ✨ Hand workflow-model states to their agent profiles

The eval cycle now reads the bound model: an item whose state the model
hands to a profile (TechDocs Accepted -> techdocs-drafter, Drafting on
/verify -> techdocs-verifier) is withheld from every generic lane, claimed
for the agent that fills the profile on the issue-claims ledger, and kicked
once. The hand-off key (item, profile, state, triggering comment) is
written to workflow-dispatch.json on delivery, so neither a later cycle
nor a restart repeats it; a failed or deferred kick is retried.

Part of the drafter hand-off for cncf/techdocs#395.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🐛 List a bound repository's drafts at most every five minutes

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>
… reloads (#18592)

* 🐛 Betty closes the loop on deep dives; research agents survive reconciles

research-1..N are added to the runtime only (not hive.yaml), and
ReconcileAgents (config reload, reviewer autoscale) removes every agent
not in the enabled config set, so the pool was emptied shortly after boot
and each meeting research request failed with "no research agent
available" while nothing was said in the meeting.

- cmd/hive: the reconcile set carries the research pool's agents.
- research.Pool: a dispatch that finds no agent re-registers them once;
  ErrNoAgents carries a sayable Reason; Status() for the settings page.
- live: a persona deep dive that cannot start, errors, or runs past
  5 minutes is answered with "I couldn't look that up: <reason>." in
  the channel it was asked in; one progress note after 30 s; a spoken
  question's follow-up is spoken.
- Settings, Meeting attendee: Research section with agents, availability
  and a "No research agent available" warning.

Part of #18590

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🐛 tests: set agents through AgentRuntimeConfig

Part of #18590

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>
…atus-card sections (quiet mode) (#18616)

* ✨ Review follow-ups, trust-only 090 and issue pr-link notes become status-card sections (quiet mode)

In github.notifications.mode: quiet the review Follow-ups checklist is the
collapsible review-followups section of the PR's hive:status card (ticks
kept via the new prstatus.WriteFunc), a 090 ready-for-human-merge entry
whose only objection is the author's trust tier is the stage-ready line,
and the issue-side PR-link stage note is the issue card's issue-pr-link
section. Every 085 and a held or manual-merge 090 still post a comment.

Fixes #18606

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🐛 status-card follow-ups use their own marker; tests expect neutralised mentions

The card section carried the legacy Follow-ups comment marker, so the next
pass read the card as the legacy comment and EditIssueMarkerComment
rewrote the whole card. Stamp the section with
<!-- hive:review-followups-card --> and skip status comments in the legacy
check. The 090 card line goes through prstatus.Write, which neutralises
'@sha' to a code span; the test now expects that.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>
…r maintainer reporters (#18617)

* 🌱 ci: no mutation comment for an error verdict; no reopen hint for bot or maintainer reporters

mutation-report.sh post no longer creates a <!-- hive-mutation --> comment
for an 'error' verdict (no report, nothing to act on): the report stays in
the job summary and the failing verdict step, and an earlier finding comment
is edited so it is not stale. issue-closed-reopen-hint.yml skips issues
whose reporter is a bot or OWNER/MEMBER/COLLABORATOR. pr-overlap.sh already
posts only when a sibling PR overlaps (#17870); unchanged.

Fixes #18607

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🌱 changelog fragment for #18607

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🌱 re-pin TRUSTED_SCRIPTS_TREE for the mutation-report.sh change

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>
…18621)

Until the consent notice is delivered (consent_posted_at), every
transcript segment, draft and chat line is discarded in the manager:
not stored and not emitted to listeners (Betty, Spektacular, research,
facts, Inbox hand-off). Only a pre_consent_dropped count is kept. A
leave phrase is still honoured and the line itself is not kept.

Lines that arrive after the notice but belong before it are dropped
too: seq at or below Quorum's transcript cursor when the notice landed
(consent_seq), chat stamped earlier, and for two minutes segments that
began before the last speech heard while pending (consent_speech_end).
A reconnect or restart while pending asks Quorum for no replay, and
dropped lines advance the replay cursor.

Refs #18590

Signed-off-by: Andy Anderson <andy@clubanderson.com>
…#18624)

The has-open-pr label write shared the caller's 15s deadline with the
open-PR listing ahead of it, so a slow listing of a large repo left it a
spent context. The write failed with context deadline exceeded, the issue
never got the label, and every later claim pass retried it and warned
again, which filed an unclassified_error_repeated self-report.

- give the label write its own 10s budget, detached from the caller
- remember a failed write per issue: 15m after a transient failure, 6h
  after a refusal (403/404/410/422), and log refusals at INFO
- add the open_pr_guard_label_failed fleet-report class for the
  remaining repeated WARNs

Fixes #18589

Signed-off-by: Andy Anderson <andy@clubanderson.com>
#18609's unshallow step fetched full blob history and measured 38-42s on
the self-hosted pool, slower than the all-refs checkout it replaced. The
checker reads only commits and trees, so fetch with --filter=blob:none
(measured 84s -> 14s and 277 MB -> 24 MB locally for the same refs).

Signed-off-by: Andy Anderson <andy@clubanderson.com>
The test returned once the instruction was typed, while the queue worker
and seed delivery were still writing (touch, audit, inbox routing). TempDir
cleanup then raced those writes (directory not empty). Wait for the audit
and for the queue worker to exit before the test ends.

Fixes #18545

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.293.0 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
)

* ✨ Owner-only Send to <profile> on model-owned stage-tracker rows

A row of a model-bound repository whose state the model hands to an agent
profile offers the owner Send to <profile> in its menu, backed by the
owner-only POST /api/workflows/dispatch: the item is read fresh, the
agent resolved (a profile disabled for automatic dispatch still
resolves), the issue claimed first and the agent kicked; the hand-off is
recorded once the kick lands so the automatic pass does not repeat it.
Audited workflow_dispatch; openapi and api-reference updated.

Part of the drafter hand-off for cncf/techdocs#395.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🐛 Register the kicked agent in the dispatch endpoint test runtime

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>
…18602)

Record the #18596 comparison as a design page: phone dial-in, a desktop
companion that streams the user's own call audio, and Zoom's RTMP live
stream, each against the free-account, bot-rule, consent and cost
constraints. Recommends the desktop companion (macOS first) and records
its proposed streaming contract, per-user companion token, distribution
plan and prototype PR set. Indexed in docs/design/README.md and linked
from meetings.md, which now notes that Zoom refuses web-client bots.

Hive-Run: #18596
Hive-Plan: 18596 recommendation and prototype PR set
Hive-Spec: #18596#recommendation

Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
…rted clusters included (#18639)

The host_aliases reconcile sweep (#17805) patches Deployments over kubectl,
but vllm-d and a-ks-wec2 are push-reported (pull_only) clusters the hub
cannot reach, so the sweep skipped every hive there silently. Only spokes
rendered from the template after #17805 carried the aliases.

The hub now sends the SaaS record cluster's host_aliases on every heartbeat
response and the spoke converges its own Deployment with a JSON patch
(exact for the managed hostnames, unrelated aliases kept, throttled to one
check per 15 minutes). The hub sweep reports push-reported clusters and
WARNs on unreadable or unreachable Deployments instead of logging at Debug.

Fixes #18637

Signed-off-by: Andy Anderson <andy@clubanderson.com>
* ✨ meetings: desktop companion meetings (/api/companion/*)

A companion meeting is fed by the desktop companion: a person's own meeting
client audio (call) and microphone (mic), captured on their computer after a
versioned consent confirmation, relayed as 16 kHz PCM to Quorum's companion
platform (quorum 0.3.0). Betty's replies go to the companion window through
Quorum's outbox. Owner or read-write; a companion meeting is usable only by
its starter (or an owner).

Refs #18596

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 📖 docs: rewrite api-reference citations shifted by the companion routes

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🐛 meetings: companion handlers use the logging meetingsError (#18600)

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Co-authored-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
quorum.mjs sha256 from the v0.3.0 release's quorum.mjs.sha256; davey stays
0.1.12 (quorum's package-lock.json).

Refs #18596

Signed-off-by: Andy Anderson <andy@clubanderson.com>
…e queue, delete finished meetings, quiet Spektacular restarts (#18635)

* 🐛 Meetings: don't restart-loop the Spektacular stream child when live mode isn't available

The pinned spektacular (0.31.0) has no `meeting` command
(hivecommons/spektacular#126 is unreleased), so every live meeting child
printed cobra's unknown-command envelope and exited 1. The stream
restarted it five times per meeting, each restart a WARN, which the
slog feed self-reported as unclassified_error_repeated (#18630), and the
session warned once per transcript line it could not forward.

- spektacular.Stream gains an optional Probe (`meeting --help`), run
  once per installed binary; an unknown command marks the stream
  Unsupported: no child is started or restarted, one INFO line per
  binary. A child whose own exit output says unknown command is not
  restarted either.
- Restart lines are WARN at most once per BackoffMax window (INFO
  otherwise) and map to a new log-fed class spek_stream_unavailable.
- The live session treats an unsupported Spek as off from the start
  (panel status unchanged), stops forwarding once Spek is gone, and warns
  about a failed forward only on the transition to paused.

Fixes #18630

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* ✨ Meetings: delete finished meetings and stale join requests

Owner-only DELETE /api/meetings/{id} for meetings in a final state and
pending join requests (declined, then removed); 409 while hive is still
in the meeting. Removes the record, transcript and live state, erases
the meeting in Vexa with Quorum meeting.delete (best effort, surfaced as
upstream_error) and drops the Calendar entry that existed only for it.
POST /api/meetings/clear-finished deletes all finished meetings older
than now; DELETE /api/meetings/schedule/{eid} deletes a past Calendar
entry with its meetings. Knowledge facts and drafts are not touched.
Audited as meeting_delete / meeting_schedule_delete.

UI: 🗑 Delete on finished and join-request rows, Clear finished, and
🗑 Delete on past Calendar entries, all behind the in-page confirm.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🐛 Meetings delete: use s.meetingsError after the v5 merge (#18600)

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🐛 Meetings delete: clear consent tries and load the delete helpers in the role-race test

Carries the fixes from #18615's v5 merge: Delete also forgets the
consent attempt count, and the meetings/calendar role-race harness
extracts meetingsFinished, meetingsCanDelete, meetingsDeleteButtonHtml,
calendarCanDelete and their constants.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* ✨ Betty runs several model calls per meeting at once

A meeting may now have up to meetings.llm.per_meeting_in_flight (default
3, never above max_in_flight) model calls in flight, so a second request
no longer waits for the first answer. A per-meeting Gate bounds the calls
and reserves each in-flight call's expected cost against the token
budget, so concurrent calls cannot all pass the check on the same ledger
total. On a warm CLI backend the meeting keeps a pool of warm CLIs (one
turn per process, since stream results carry no request id) that grows
only when calls overlap.

Part of #18590.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🌱 Show meetings.llm.per_meeting_in_flight in the meetings settings

The Settings parity guard needs every hive.yaml leaf referenced by the
Settings UI; the meetings settings' effective values now include it.

Part of #18590.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* ✨ Betty names who and what each answer is for when requests overlap

With more than one request in flight, other lines said since the
request, or an answer later than 8 s, each answer opens with the asker's
display name (first name when spoken, never an @mention) and a short
topic phrase: the model's new "topic" label, else the request's own
words. Two or more requests in hand post one queue note per minute
(chat, rate limited, not charged), and spoken acks name their asker
when others are waiting.

Part of #18590.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* ✨ Betty speaks ready answers shortest first and moves a long voice queue to chat

Quorum's say queues clips and plays them in order, so hive keeps an
estimate of the queued speech. Spoken answers ready in the same loop turn
are said back to back, shortest first; one that would wait behind more
than 20 s goes to chat with one spoken "I've put the rest in chat"; an
ack behind more than 8 s of speech is skipped. Answers to addressed
requests may take meetings.chat_answer_burst (3) extra chat posts a
minute past the chat rate.

Part of #18590.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🌱 Show meetings.chat_answer_burst in the meetings settings

Part of #18590.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* ✨ Betty times every answer stage and answers live-state questions without waiting for search

Each answer carries heard, retrieval, model and answer-ready timings with
its source and budget (4 s for the hive's live state, 8 s otherwise); the
live session adds delivery and say times and keeps the last 20 with a
latency summary in the live state served by the meeting detail API.
Gather stops waiting once the hive status retriever answers.

Part of #18590.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* ✨ Betty cites the sources of chat answers and says when she is not sure

Chat answers end with up to two sources the model reported using (web
link, work item id, knowledge fact, code map or hive live status); the
prompt asks for issue and PR numbers and forbids guessing; a
low-confidence addressed answer not from the live state is hedged.

Part of #18590.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 📖 Refresh meetings API doc citations for the combined Betty changes

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🐛 Betty attribution tests expect the source a chat answer now cites

With #18631's citations combined, an attributed chat answer ends with its
source, so the attribution tests compare against that full text.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>
…#18638)

* ✨ Sessions: per-session git worktrees with a locked shared git config

Each Sessions pane opens in its own git worktree of the hive's one shared
clone, on branch hive-session/<id>, so each session has its own Spektacular
workflow state, checked-out branch and uncommitted work (#18588).

The shared clone's git config and hooks are locked: root rewrites
.git/config from scratch (no git as root) as root:<gid> 0644 with
extensions.worktreeConfig, empties hooks/, info/ and modules/ into root
0755 dirs, places root-owned config.worktree and commondir placeholders,
keeps objects/refs/logs group-writable, and makes .git, worktrees/ and the
clone 3770. It runs before any worktree of a clone is handed out and once
per clone at boot. A session's worktree entry is created with no group
write; panes get no safe.directory, so git refuses a swapped .git. The
hive's own git always passes -c core.hooksPath=/dev/null
-c core.fsmonitor=false.

Existence checks run in the add/remove scripts as the session uid (the hive
runs as dev, outside the sessions group): a resume is a no-op, a missing
clone is reported, a worktree whose .git is not the session's own is
refused. Removal auto-saves uncommitted work on the session branch first.
The worktree sweep does not run while the sessions store failed to load or
an unreadable copy is set aside.

Builds on the design in #18613 by Karibhou.

Fixes #18588

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🌱 Sessions: split worktree code into its own file, re-pin API citations

Moves the worktree scripts and functions out of usersession_workspace.go
(over the 800-line crux limit) into usersession_worktree.go, updates the
add-count test (the add script runs on every start, as the session uid),
and re-pins the sessions API citations with check-docs-citations.py --fix.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

Co-authored-by: Danathar <6772335+Danathar@users.noreply.github.com>
* 🐛 fix: wait for seed queue before test cleanup

Wait for the seed queue worker to finish its session store writes before temporary directory cleanup.

Hive-Run: #18454
Hive-Plan: dashboard-seed-cleanup
Hive-Spec: issue-18454#dashboard-test-cleanup
Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>

* fix: wait for all seed test queue workers

Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>

* test: share pending seed cleanup

Signed-off-by: Karibhou <157208370+Karibhou@users.noreply.github.com>
…8643)

Each owner or read-write user mints a companion token on /companion/token
(shown once, SHA-256 stored, one per user). authenticate admits it only on
/api/companion/info and /api/companion/meetings/*, as the minting user at
their live role (refused below read-write). The hub waves those routes
through to the spoke, which does the check; the token page stays gated.

Refs #18596

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.294.0 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
Automated pin bump (#8419). Digests recomputed from the downloaded
release artifacts by src/scripts/cli-pin-bump.sh:

  VERSION=18.22.0
  SHA256_AMD64=f706b27ba845834d8f8360705a2e9ba1534f3593fa24411d41358272de33642b
  SHA256_ARM64=7238dd213d5c61bc9bf51735d552bc71901fdd44329f862b0a971146b1cdac3e

Signed-off-by: hive-release[bot] <hive-release@hive.kubestellar.io>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Automated pin bump (#8419). Digests recomputed from the downloaded
release artifacts by src/scripts/cli-pin-bump.sh:

  VERSION=2.1.326

Signed-off-by: hive-release[bot] <hive-release@hive.kubestellar.io>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
…th (#18604)

The guard was cancelled at its 10-minute timeout whenever the
whisper-linux-amd64 gha cache missed. The repo's Actions cache runs at
12-23 GB against a 10 GB cap, so LRU eviction regularly drops the
whisper-builder blobs; the hosted 4-vCPU runner then compiles FFmpeg and
whisper.cpp from source (~8.5 min serial chain) and the job needs ~13 min.
Warm runs measure 6.5-8 min and are unaffected.

Raise the timeout to 20 min (cold path plus ~50% headroom) and skip the
buildx post-step teardown on the ephemeral runner (16-36s per run).
Regenerated the integration workflows from v2-ci.yml.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Avoid collisions with delayed tmux operations from shuffled tests and drain the readiness helper before session teardown.

Hive-Run: #18626
Hive-Plan: restart-kick-flake
Hive-Spec: restart-kick#readiness
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.295.0 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
@kubestellar-prow kubestellar-prow Bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 17, 2026
@hivecommons-hive

hivecommons-hive Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

ℹ️ Sentinel: informational, author is trusted (owner), merge is not blocked. Head 63e28544bd65 matched:

  • sensitive_path: changes 8 sensitive path(s) (.github/workflows/dco-squash-attribution.yml, .github/workflows/docker.yml, .github/workflows/integration-candidate.yml, .github/workflows/integration-technical-v2-ci.yml, .github/workflows/issue-closed-reopen-hint.yml, +3 more)

No sentinel-alert label was added. The finding is recorded in the dashboard Security tab and /api/sentinel; set sentinel.trusted_authors_block: true to block trusted authors too.

clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

  • native-queue-policy

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

Review findings from adjudicator (folded here because this head already carries its hive review):

HUMAN DECISION NEEDED — clubanderson: the PR diff exceeds GitHub's 20,000-line limit, so the correctness perspective could not read it in full. A human or CI must vouch for the rest.

Reviewed head 63e2854. gh pr diff returned HTTP 406 (diff too large), and the file list is capped at 100 entries. I read selected files at head instead. I did not read the whole merge, and the PR body says nothing was built or tested locally.

Read and judged sound:

  • src/cmd/hive/main_eval_cycle.go:1179-1186 and :1730-1757. The hand-ported workflow-dispatch hooks are wired correctly. onDeferred and onFailed call releaseWorkflowDispatch. onDelivered calls recordWorkflowDispatchDelivered and writes the audit entry.
  • 🐛 Copilot CLI's own save re-breaks the config.json relink after launch (#18445 follow-up) #18671 acceptance (src/crux/agent/manager_poll.go:34, copilot_config_bridge_sync_test.go:54,86,121). The poll loop relinks after the CLI's save. The tests cover relink with CLI-field merge, a dashboard login reaching a running agent, and the keep-the-login-when-shared-is-empty guard.

Open question, not asserted as a defect: planWorkflowDispatchKicks (src/cmd/hive/workflow_dispatch.go:~280) takes the issue claim and calls markPending before the kick. Messages dropped by the pre-dispatch gates (freshness, provider budget, quota hold, drain, main_eval_cycle.go:~1202-1285) never reach onDeferred/onFailed. The pending marker expires on its TTL, but the 8h issue claim would persist. This is v5 behavior carried over and out of scope here.

Not verified: the other ~95 files (meetings companion, worktrees, openapi/doc merges, workflows). Please confirm CI is green, especially the Go tests for the touched packages.

Review follow-ups: 1 open of 1 (below review.backlog.min_severity: P2)

Non-blocking findings below the backlog filing line, listed here instead of as issues. Tick them off as they are fixed; set review.backlog.min_severity: P3 to file every finding.

  • P3 low correctness — Workflow issue claim can outlive a kick dropped by pre-dispatch gates (src/cmd/hive/workflow_dispatch.go:280): planWorkflowDispatchKicks claims the issue (8h TTL) and marks the item pending before the kick passes the freshness, budget, quota and drain gates. A dropped message never reaches onDeferred or onFai…

…reuses them (#18687)

Measured on v5 after #18674: the whisper-builder warm step hit the GHCR
registry cache (all layers CACHED in about a second), but the main build
step then recompiled FFmpeg and whisper.cpp. Earlier runs show the same
for tmux and for the old gha whisper scope: a warm-step cache hit with no
output leaves nothing in the builder's local cache, and the main build was
only served when the warm step had missed and compiled locally.

Export each warmed stage to /dev/null so its layers are pulled and recorded
in the local builder cache before the main build runs.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HUMAN DECISION NEEDED — @clubanderson: the full diff exceeds GitHub's 20,000-line limit (HTTP 406), so a security reviewer could not read the Go/JS changes in this 46-commit v5→v6 merge; confirm CI plus a human skim cover them.

Security perspective, head 63e2854.

Read: the .github/ patches (7 files, via the per-file pulls API) and docker.yml at head. Not read: the Go, JS, openapi and docs changes (including the #18673 Copilot config.json relink that satisfies #18671, /api/companion/* per-user tokens, and /api/workflows/dispatch). I make no claim about those.

What I read in the workflows:

  • No new triggers, no pull_request_target, and no new secrets.* references.
  • docker.yml:318-327: the GHCR login now also runs on same-repo PR builds. The job already has packages: write (docker.yml:79). The registry cache-to is gated on push == 'true', so PR builds only read the cache. Fork PRs never reach the job. I see no exploit.
  • dco-squash-attribution.yml: HEAD_SHA, BASE_SHA and DEFAULT_BRANCH are passed through env: and quoted, so there is no shell injection.
  • integration-governance.cjs:12: TRUSTED_SCRIPTS_TREE is re-pinned to f2fe6fe1…. I could not verify that this is the real src/scripts tree hash. It is a trust anchor, so someone should recompute it with git rev-parse <head>:src/scripts.

— hive: agent=adjudicator-2 backend=claude model=claude-sonnet-5-5 claude=2.1.326

Fixes #18692

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson clubanderson changed the title 🌱 chore: top up v6 from v5 (2026-11-17, #2) 🌱 chore: top up v6 from v5 (2026-11-17, second pass) Nov 17, 2026
clubanderson and others added 2 commits November 17, 2026 08:16
Merge origin/v5 (ff268e2, v5.298.1 + #18674 + #18673) into v6. Carries
46 v5 commits, b2a1c14..ff268e2, including #18673 (Copilot config.json
link survives the CLI's own save, fixes #18671).

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Automated release commit. Compiles changelog.d/ fragments and moves
the CHANGELOG.md Unreleased section into a dated v5.298.2 entry.
See src/docs/releases.md.

Signed-off-by: hive-release-bot <actions@github.com>
…#18695

Second merge of origin/v5 (5440aa2) into the top-up branch for the two
v5 commits that landed while the first merge was being resolved.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Third merge of origin/v5 (ff89890) into the top-up branch for the
v5.298.2 release-gate commits that landed while the branch was being pushed.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
I, Andy Anderson <andy@clubanderson.com>, hereby add my Signed-off-by to this commit: f444b4f
I, Andy Anderson <andy@clubanderson.com>, hereby add my Signed-off-by to this commit: 3d8d438

Signed-off-by: Andy Anderson <andy@clubanderson.com>
clubanderson and others added 7 commits November 17, 2026 13:41
…gent fills (#18691)

* 🐛 Workflow dispatch: fall back to the hive's issue worker or reviewer, and show a profile nothing fills

A bound workflow model hands some states to an agent profile, but the
resolver only accepted a pinned agent, an agent named after the profile,
or a writer, docs or feature agent. A standard roster has none of those,
so the drafter never started and nothing in the dashboard said why.

- config.ResolveWorkflowDispatch ends with a last resort: the issue
  worker (scanner role, classify.DefaultLane) for a profile that opens a
  pull request, the reviewer for one that reviews, in both cases only an
  agent that serves the bound repository. No other role is picked.
- GET /api/workflows lists each bound profile's agent or the reason
  there is none; the Settings -> Repos workflow row warns and offers a
  picker that saves workflow.dispatch.profiles.<profile>.agent through
  PUT /api/workflows/dispatch/profiles.
- The stage tracker carries the reason onto the item's row, and the
  manual send answers with it and where to fix it.

Fixes #18690

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* 🐛 Document the profile pin route in the OpenAPI spec; keep the gap badge rule out of the sentinel CSS block

Fixes #18690

Signed-off-by: Andy Anderson <andy@clubanderson.com>
…84+hivecommons-hive[bot]@users.noreply.github.com>

On behalf of hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>, I, Andy Anderson <andy@clubanderson.com>, hereby add my Signed-off-by to this commit: 0b8ad82
On behalf of hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>, I, Andy Anderson <andy@clubanderson.com>, hereby add my Signed-off-by to this commit: 02d2850

Their squash commits carry a Signed-off-by for a different identity than the author.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
…on.com>

On behalf of Andy Anderson <andy@clubanderson.com>, I, Andy Anderson <andy@clubanderson.com>, hereby add my Signed-off-by to this commit: f444b4f
On behalf of Andy Anderson <andy@clubanderson.com>, I, Andy Anderson <andy@clubanderson.com>, hereby add my Signed-off-by to this commit: 3d8d438

Their Signed-off-by lines name the release bot rather than the author address.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
I, Andy Anderson <andy@clubanderson.com>, hereby add my Signed-off-by to this commit: f444b4f

Signed-off-by: Andy Anderson <andy@clubanderson.com>
I, Andy Anderson <andy@clubanderson.com>, hereby add my Signed-off-by to this commit: 3d8d438

Signed-off-by: Andy Anderson <andy@clubanderson.com>
* 🌱 ci: let the DCO app honour an author's own remediation commit

Adds .github/dco.yml with allowRemediationCommits.individual: true so an
author can vouch for their own earlier commits whose author email had no
matching Signed-off-by, which is what blocks v5 -> v6 top-ups that carry
image-bump commits (#18697). Third-party remediation stays off.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

* changelog: fragment for #18703

Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>

* 🌱 changelog: make the dco.yml fragment a single entry bullet

The fragment is the entry itself and must start with '- '; the compiler owns
the headings. Drop the duplicate fragment the changelog bot added for #18703.

Signed-off-by: Andy Anderson <andy@clubanderson.com>

---------

Signed-off-by: Andy Anderson <andy@clubanderson.com>
Signed-off-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…1235

Carries #18691 and #18703 (.github/dco.yml) into the v6 top-up.

Conflict: dashboard/openapi.json. Kept v6's document and added v5's new
/api/workflows/dispatch/profiles path (#18691) beside /api/workflows/dispatch.

Signed-off-by: Andy Anderson <andy@clubanderson.com>
@clubanderson clubanderson added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 17, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants