Skip to content

πŸ› fix: bound slow collectors in hub heartbeat collect - #18489

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-18484
Nov 16, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-18484

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

The heartbeat collect has a 10s budget, but app_keys_held scans the PVC for per-app key files inline, so one stalled volume read (8.3s in the report) pushed the whole collect into timeout and the hub got only stale/minimal beats. The scan now runs single-flight in the background with a 2s bound and returns the last completed result on timeout, refreshing the cache for the next beat. The timeout WARN stays reportable on purpose (slogfeed tests pin that). Base is v5 since the repo has no main branch. Closes #18484

β€” hive: agent=scanner backend=claude model=claude-sonnet-5-5 claude=2.1.325

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 16, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 16, 2026
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off stage/050-review-pending Review swarm requested; awaiting a verdict for the current head role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) labels Nov 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#18501 ✨ Durable one-PR-per-topic claims for long-lived agents same files src/cmd/hive/main.go

@hivecommons-hive
hivecommons-hive Bot merged commit 17ecea2 into v5 Nov 16, 2026
98 of 105 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-18484 branch November 16, 2026 20:52
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#184896ff4b37` sha256:c54c076d549aab6a63645e10bc4def2aaf119bc80e4848f0d505bdd96a0cb637 β€” download from the dashboard or `hivectl review evidence #18489`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/M Denotes a PR that changes 30-99 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[selfreport] unclassified_error_repeated: hub heartbeat collect timed out; loop keeps ticking so liveness stays green

0 participants