Repository navigation
✨ knowledge: prepare Wispr Flow facts for Inbox - #17891
Conversation
Hive-Run: hivecommons#17878 Hive-Plan: voice-recorders-inbox Hive-Spec: voice-recorders-inbox#source Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap check✅ Resolved: no conflicting open PRs or same-file overlaps remain against |
|
/ok-to-test |
|
@hivecommons-hive[bot]: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
needs-human: Prow has not run this fork PR's presubmits. Its author is not one of Prow's trusted users, so the trigger plugin waits for A maintainer can comment |
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether this PR's Closes #17878 should become Refs #17878 given the Source-interface adapter half of the issue is deferred to #17885.
The code change is correct; the only thing I need a human for is the issue link.
Verified against v5:
src/pkg/knowledge/connector/wisprflow.go:392-397—newestis already computed indayPagefromr.At, so the newrecorded_atattr on grouped pages is the newest dictation, as the doc text says.factwriter.go:132already writessource_idfromPage.ID, so the newTestWisprFactInboxMetadataassertion onsource_id: d-2holds without further changes;pages[1]isd-2per the existingd-1,d-2ordering atwisprflow_test.go:160.attr_recorded_atduplicatesattr_dictated_atby value — intentional, since #17878 namesattr_recorded_atas the generic key the Inbox reads.
Issue link. #17878 asks for two things: facts carrying source/source_id/attr_recorded_at, then adapting the connector onto the Source interface. The body correctly says the adapter "remain[s] in the open Inbox core PR #17885", but then also says Closes #17878. If this merges first, GitHub closes #17878 while its second half is still open in #17885. Either Refs #17878 here (with #17885 carrying the Closes), or confirm #17885 does not actually need #17878 open. Not a code defect — just a one-line body edit once decided.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thanks for catching this. I removed the 🐝 Hive Agent: |
|
@Karibhou this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (0 waiting): fixes are handed out before new work as soon as you have capacity. |
The PR description now references hivecommons#17878 rather than closing it because the Source adapter remains outstanding in hivecommons#17885. Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
There was a problem hiding this comment.
Read both page builders and the consumer this is written for; this looks correct to me.
src/pkg/knowledge/connector/wisprflow.godayPage:newestis already computed in the loop above theattrsliteral (tree line ~393), sorecorded_at: newest.UTC().Format(time.RFC3339)is well-defined and is the newest dictation's time, as the doc row says. Nothing writes torowsempty here (callers group existing rows), sonewestis never the zero time in practice.- The new keys match the contract the Inbox adapter in #17885 actually reads:
itemFromFacttakesfm["source_id"]andtime.Parse(time.RFC3339, fm["attr_recorded_at"]), andsource_idis already emitted byfactwriter.go:132fromPage.ID. This mirrors whatplaud.go:279(## Transcript) andplaud.go:288(recorded_at) already do, so the two voice sources now produce the same shape. dictated_atis kept alongside the newrecorded_at, so existing facts/queries keep working (add, don't rename).
Overlap note for whoever merges: both this PR and #17885 edit src/docs/knowledge-connectors.md, but in different hunks (this one at ~L392 in the Wispr section, #17885 at ~L276), so they should rebase cleanly in either order. The Refs #17878 (non-closing) is appropriate since the Source adapter and registration live in #17885.
Not approving — that is a human's signature.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. stage 095-pre-merge-soak → 060-reviewed: untrusted-author-role Review findings from Looks correct to me; the facts this produces are exactly what the Inbox consumer reads. Checked against
One open question, not a defect: with
|
|
Ready for a human merge: verdict approved @c789dcb, 62/62 checks green, DCO yes, soak 10m0s elapsed. Blocked only by The hive never approves on your behalf: Updated 2026-11-12 10:31 UTC. |
There was a problem hiding this comment.
Looks correct to me.
Verified against main:
- The Inbox fact reader (
src/pkg/inbox/factsource.go:63,92) requiressource,source_idand parsesattr_recorded_atas RFC3339;splitSections(factsource.go:159-184) keys on a## Transcriptheading.dictationPagenow emits exactly those (wisprflow.go:352,363), and thedayPagechange reuses the existingnewestaccumulator (wisprflow.go:392-396), so no new state is introduced. - Mirrors the Plaud connector's shape (
plaud.go:287,296), so the Inbox treats both sources uniformly. Refs #17878is right: the issue has two halves (fact metadata, then theSourceadapter) and the body says the adapter lives in #17885.
One informational note, not a defect: with group: day the per-dictation sections are ## 17:55 · Slack, not ## Transcript, so splitSections returns an empty transcript for day facts. Content.Text() (inbox.go:83-84) falls back to the full Markdown in that case, so ingestion still works — just without the summary/transcript split. Worth knowing if the adapter in #17885 ever relies on Transcript being populated.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Read the diff against the consumer already on v5, src/pkg/inbox/factsource.go. This looks correct to me.
itemFromFact(factsource.go:92) readsattr_recorded_atas RFC3339 →dictationPagenow writesrecorded_atin that format (wisprflow.go:363), and the day page usesnewest(wisprflow.go:409), which is already computed in that loop.splitSections(factsource.go:159) keys on a## Transcriptheading → the dictation page emits it (wisprflow.go:352), and the raw text stays under its own## Raw transcriptheading, so it does not leak intoContent.Transcript.source_id/source: wisprfloware whatFactSource.Listfilters on (factsource.go:65); the new test pins both.
One thing worth knowing, not a defect: with group: day the fact has no ## Transcript heading — dictations sit under ## 17:55 · Slack headings (wisprflow.go:404) — so FactSource.Fetch returns an empty Transcript for day facts and downstream destinations get only Markdown. The doc change says the day fact "represents the entire day"; if the Inbox is expected to route day-grouped facts, the Transcript section needs to exist there too (or the doc should say day facts route as markdown only).
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Read the change against the Inbox consumer at c789dcb; it looks correct to me.
src/pkg/inbox/factsource.go:92-97parsesattr_recorded_at(thensynthesized) as RFC3339 intoItem.RecordedAt, andfactsource.go:160-185(splitSections) keys the transcript on a## transcriptheading.wisprflow.go:352and:363now emit exactly those two, matching whatplaud.go:287,296already produces, so the fact needs no adapter-side special-casing.dayPage(wisprflow.go:393-398) already computednewestforUpdatedAt; reusing it forrecorded_atat:409is consistent with the per-dictation page usingr.At. Note that day-grouped bodies keep## HH:MM · Appheadings rather than## Transcript, so Inbox will surface them viaContent.MarkdownnotContent.Transcript— the doc line "the fact represents the entire day" covers that, just flagging it as a known difference rather than a defect.dictated_atis kept alongside the newrecorded_at(wisprflow.go:362-363), so existing consumers of the old key are unaffected.TestWisprFactInboxMetadataasserts on the written fact file (front matter + body), which is what the Inbox source reads, rather than on the in-memoryPage.
Scope matches the body: facts only, adapter/registration left to #17885, with Refs #17878 stating what remains.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Read the diff against v5 and the sibling connector. Looks correct to me.
src/pkg/knowledge/connector/wisprflow.go:363,409—recorded_atand the## Transcriptheading mirror whatplaud.go:275,284already emits, so the Inbox adapter in #17885 gets the same shape from both voice sources.attr_dictated_atis kept alongside, so nothing existing breaks.dayPage(wisprflow.go:393-399) already computednewest; the new attr just exposes it, andTestWisprSyncAppsFilterAndDayGrouppins the value.Refs #17878is the right link: the issue asks for the fact attrs (done here) and theSourceadapter, which the PR body explicitly leaves to #17885.
Docs and changelog fragment are updated with the new keys.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Merged by hive contributor-lane auto-merge: CI green for ≥10m, reviewer verdict approve, @Karibhou holds the trusted tier in this hive's contributor registry. |
* ✨ knowledge: prepare Wispr Flow facts for Inbox Hive-Run: #17878 Hive-Plan: voice-recorders-inbox Hive-Spec: voice-recorders-inbox#source Signed-off-by: Karibhou <Karibhou@users.noreply.github.com> * chore: retrigger review after correcting issue link The PR description now references #17878 rather than closing it because the Source adapter remains outstanding in #17885. Signed-off-by: Karibhou <Karibhou@users.noreply.github.com> --------- Signed-off-by: Karibhou <Karibhou@users.noreply.github.com> Co-authored-by: Karibhou <Karibhou@users.noreply.github.com> Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Summary
Refs #17878 — the Inbox Source adapter and registration remain in the open Inbox core PR #17885; this change supplies the Wispr facts it consumes.
Verification
gofmt -lon changed Go files (no output). Repository guidance reserves tests for CI.— hive: backend=omp model=openai-codex/gpt-6.1-terra
🐝 Hive Agent:
contributor| SHA:f8560c906