Repository navigation
🌱 chore: remove tracked build artifact from survey tool - #17660
Conversation
The 4.4 MB compiled binary src/cmd/workflow-survey/workflow-survey was committed to v6 with the workflow-model stack. Built artifacts belong in .gitignore, not in the repository index. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Changelog: this PR changes code but carries no changelog entry If it is user-visible — a feature, a fix an operator would notice, a This is a reminder, not a gate; it never blocks a merge. |
Generated by changelog-fragment-guard from the PR title (#5675). Edit the wording freely, or replace this file with the no-changelog label if the change is not user-visible. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Evidence bundle `#17660a959094` sha256:a6bf97fea1d21395acdabdb6c8514f6fe4d091ffe921dc9a30942c9294fc177d — download from the dashboard or `hivectl review evidence #17660`. |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
There was a problem hiding this comment.
Verified against v6 and the sibling PRs; this looks correct to me.
src/cmd/workflow-survey/onv6containsmain.go,main_test.goand the 4.4 MBworkflow-surveyexecutable (mode 100755). Only the executable is deleted; the Go sources are untouched.src/.gitignore:9—/cmd/workflow-survey/workflow-surveyis anchored to thesrc/directory that owns the.gitignore, so it matches exactlysrc/cmd/workflow-survey/workflow-surveyand nothing else. Ago buildrun inside that directory will not re-add it.- #17654 asked for the removal "in the PR that introduced it". #17648 (the open P1+P2 stack, also based on
v6) touches onlysrc/cmd/workflow-survey/main.goand does not carry the binary, so the artifact lives solely in thev6base and this standalone PR is the right place to drop it. No conflict with #17648. changelog.d/changed-17660.mduses a valid category and the single-bullet form the guard expects.
Two checks on the current head show CANCELLED (superseded run) and build-go is still pending — nothing in this diff can affect a Go build, so that is CI scheduling, not the change.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Closes #17654
The 4.4 MB
src/cmd/workflow-survey/workflow-surveyexecutable was committed tov6with the workflow-model stack. It is a build output ofsrc/cmd/workflow-survey, not source, so it is removed from the index and the path is ignored so a localgo buildin that directory cannot re-add it. Targetsv6because the artifact exists only there (not onv5).— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88