Skip to content

🌱 chore: remove tracked build artifact from survey tool - #17660

Merged
hivecommons-hive[bot] merged 3 commits into
v6from
scanner/fix-17654
Nov 11, 2026
Merged

hivecommons-hive[bot] merged 3 commits into
v6from
scanner/fix-17654

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Closes #17654

The 4.4 MB src/cmd/workflow-survey/workflow-survey executable was committed to v6 with the workflow-model stack. It is a build output of src/cmd/workflow-survey, not source, so it is removed from the index and the path is ignored so a local go build in that directory cannot re-add it. Targets v6 because the artifact exists only there (not on v5).

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

The 4.4 MB compiled binary src/cmd/workflow-survey/workflow-survey was committed to v6 with the workflow-model stack. Built artifacts belong in .gitignore, not in the repository index.

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Nov 11, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions

Copy link
Copy Markdown
Contributor

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible — a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking —
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly — that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 11, 2026
Generated by changelog-fragment-guard from the PR title (#5675).
Edit the wording freely, or replace this file with the no-changelog
label if the change is not user-visible.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive

hivecommons-hive Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor Author

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Evidence bundle `#17660a959094` sha256:a6bf97fea1d21395acdabdb6c8514f6fe4d091ffe921dc9a30942c9294fc177d — download from the dashboard or `hivectl review evidence #17660`.

@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v6

Conflicts are checked with every PR merged onto the current tip of v6, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 11, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against v6 and the sibling PRs; this looks correct to me.

  • src/cmd/workflow-survey/ on v6 contains main.go, main_test.go and the 4.4 MB workflow-survey executable (mode 100755). Only the executable is deleted; the Go sources are untouched.
  • src/.gitignore:9 — /cmd/workflow-survey/workflow-survey is anchored to the src/ directory that owns the .gitignore, so it matches exactly src/cmd/workflow-survey/workflow-survey and nothing else. A go build run inside that directory will not re-add it.
  • #17654 asked for the removal "in the PR that introduced it". #17648 (the open P1+P2 stack, also based on v6) touches only src/cmd/workflow-survey/main.go and does not carry the binary, so the artifact lives solely in the v6 base and this standalone PR is the right place to drop it. No conflict with #17648.
  • changelog.d/changed-17660.md uses a valid category and the single-bullet form the guard expects.

Two checks on the current head show CANCELLED (superseded run) and build-go is still pending — nothing in this diff can affect a Go build, so that is CI scheduling, not the change.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit dd475d9 into v6 Nov 11, 2026
83 of 86 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-17654 branch November 11, 2026 06:51
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[reviewer] Review backlog (style): 4.4 MB compiled binary tracked under src/cmd/workflow-survey

0 participants